Skip to content

Commit e8f7384

Browse files
committed
remove view override flag in benchmarks
1 parent 29fb559 commit e8f7384

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

benchmarks/src/clickbench.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,7 @@ impl RunOpt {
116116
None => queries.min_query_id()..=queries.max_query_id(),
117117
};
118118

119-
let mut config = self.common.config();
120-
config
121-
.options_mut()
122-
.execution
123-
.parquet
124-
.schema_force_view_types = self.common.force_view_types;
125-
119+
let config = self.common.config();
126120
let ctx = SessionContext::new_with_config(config);
127121
self.register_hits(&ctx).await?;
128122

benchmarks/src/tpch/run.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,6 @@ impl RunOpt {
120120
.config()
121121
.with_collect_statistics(!self.disable_statistics);
122122
config.options_mut().optimizer.prefer_hash_join = self.prefer_hash_join;
123-
config
124-
.options_mut()
125-
.execution
126-
.parquet
127-
.schema_force_view_types = self.common.force_view_types;
128123
let ctx = SessionContext::new_with_config(config);
129124

130125
// register tables
@@ -345,7 +340,6 @@ mod tests {
345340
partitions: Some(2),
346341
batch_size: 8192,
347342
debug: false,
348-
force_view_types: false,
349343
};
350344
let opt = RunOpt {
351345
query: Some(query),
@@ -379,7 +373,6 @@ mod tests {
379373
partitions: Some(2),
380374
batch_size: 8192,
381375
debug: false,
382-
force_view_types: false,
383376
};
384377
let opt = RunOpt {
385378
query: Some(query),

benchmarks/src/util/options.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ pub struct CommonOpt {
3737
/// Activate debug mode to see more details
3838
#[structopt(short, long)]
3939
pub debug: bool,
40-
41-
/// If true, will use StringView/BinaryViewArray instead of String/BinaryArray
42-
/// when reading ParquetFiles
43-
#[structopt(long)]
44-
pub force_view_types: bool,
4540
}
4641

4742
impl CommonOpt {

0 commit comments

Comments
 (0)