File tree 3 files changed +4
-1
lines changed
3 files changed +4
-1
lines changed Original file line number Diff line number Diff line change @@ -321,6 +321,7 @@ impl TryFrom<&protobuf::Field> for Field {
321
321
fn try_from ( field : & protobuf:: Field ) -> Result < Self , Self :: Error > {
322
322
let datatype = field. arrow_type . as_deref ( ) . required ( "arrow_type" ) ?;
323
323
let field = if field. dict_id != 0 {
324
+ // https://github.com/apache/datafusion/issues/14173
324
325
#[ allow( deprecated) ]
325
326
Self :: new_dict (
326
327
field. name . as_str ( ) ,
@@ -436,6 +437,7 @@ impl TryFrom<&protobuf::ScalarValue> for ScalarValue {
436
437
let id = dict_batch. id ( ) ;
437
438
438
439
let fields_using_this_dictionary = {
440
+ // See https://github.com/apache/datafusion/issues/14173
439
441
#[ allow( deprecated) ]
440
442
schema. fields_with_dict_id ( id)
441
443
} ;
Original file line number Diff line number Diff line change @@ -98,6 +98,7 @@ impl TryFrom<&Field> for protobuf::Field {
98
98
children : Vec :: new ( ) ,
99
99
metadata : field. metadata ( ) . clone ( ) ,
100
100
#[ allow( deprecated) ]
101
+ // See https://github.com/apache/datafusion/issues/14173 to remove deprecated dict_id
101
102
dict_id : field. dict_id ( ) . unwrap_or ( 0 ) ,
102
103
dict_ordered : field. dict_is_ordered ( ) . unwrap_or ( false ) ,
103
104
} )
Original file line number Diff line number Diff line change @@ -1815,7 +1815,7 @@ fn round_trip_datatype() {
1815
1815
}
1816
1816
}
1817
1817
1818
- // TODO file a ticket about handling deprecated dict_id attributes
1818
+ // See https://github.com/apache/datafusion/issues/14173 to remove deprecated dict_id
1819
1819
#[ allow( deprecated) ]
1820
1820
#[ test]
1821
1821
fn roundtrip_dict_id ( ) -> Result < ( ) > {
You can’t perform that action at this time.
0 commit comments