Skip to content

Deprecate ScalarUDFImpl::invoke #13064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue Oct 22, 2024 · 2 comments
Closed

Deprecate ScalarUDFImpl::invoke #13064

alamb opened this issue Oct 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Oct 22, 2024

Is your feature request related to a problem or challenge?

in #13001 @agscpp added a general function ScalarUDFImpl::invoke_batche that handles inputs with 0 and more than 0 arguments.

Previously, there were two separate functions to handle these cases:

  1. https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#tymethod.invoke
  2. https://docs.rs/datafusion/latest/datafusion/logical_expr/trait.ScalarUDFImpl.html#method.invoke_no_args

Describe the solution you'd like

I would like to mark invoke and invoke_no_args deprecated

Describe alternatives you've considered

  1. Mark the functions deprecated, with a message to implement invoke_batch instead. for example
    #[deprecated(note = "use format! instead")]
  2. Update the documentation so invoke_batch is the main API and the documentation reflects that
  3. Update the DataFusion codebase so that the ScalarUDFImpls use invoke_batch rather than invoke and invoke_udf

Additional context

I think this is pretty well specified and largely mechanical so it would be a good first issue

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Oct 22, 2024
@notfilippo
Copy link
Contributor

take

@findepi
Copy link
Member

findepi commented Nov 11, 2024

Sorry for duplicating this in #13238. It's already in progress, so let's maybe close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants