Skip to content

Fix build issues on latest stable Rust toolchain (1.84) #14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Omega359 opened this issue Jan 9, 2025 · 4 comments · Fixed by #14065
Closed

Fix build issues on latest stable Rust toolchain (1.84) #14061

Omega359 opened this issue Jan 9, 2025 · 4 comments · Fixed by #14065
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Omega359 commented Jan 9, 2025

Describe the bug

1.84 was released today and /dev/rust_lint.sh does not currently pass under this release.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
@Omega359 Omega359 added the bug Something isn't working label Jan 9, 2025
@niebayes
Copy link
Contributor

I've also noticed that this implicit upgrade causes CI to fail, particularly for rust clippy check.

@niebayes
Copy link
Contributor

take

@jonahgao jonahgao mentioned this issue Jan 10, 2025
Merged
@jonahgao
Copy link
Member

Since it blocks many PRs, I created #14065 to fix it. cc @niebayes

@niebayes
Copy link
Contributor

Feel free. I got stuck in fixing clippy warnings unexpected cfg ....

@niebayes niebayes removed their assignment Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clippy for Rust 1.84 jonahgao/datafusion
3 participants
@Omega359 @niebayes @jonahgao