Skip to content

extended_test (with memory limit tracking) are commented out #14680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue Feb 15, 2025 · 4 comments · Fixed by #14745
Closed

extended_test (with memory limit tracking) are commented out #14680

alamb opened this issue Feb 15, 2025 · 4 comments · Fixed by #14745
Assignees
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Feb 15, 2025

Describe the bug

I commented out the extended_test in

This test was added by @2010YOUY01 in

It started failing after

There is more detail in this comment

To Reproduce

No response

Expected behavior

I would like the extended_test to be fixed so it runs regularly or is removed

Having a commented out / unrun test in the codebase is not adding any value

Additional context

No response

@2010YOUY01
Copy link
Contributor

This test is failing because it runs out of disk space, I've checked the remaining disk space after Github's CI runner has setup the rust toolchain and before running any test: It's 12GB disk space left.
The failing extended_test requires 11G, and the normal test requires 7G according to my local experiments. This disk space budget is quite tight IMO.

I'm trying to find is there any good way to free up more disk space, It's quite hard since now CI jobs are running inside the container.

# container:
# image: amd64/rust

I'm wondering is it possible not to run inside docker, and manually setup rust dependency, and this way we can delete some unused files and free up disk space.

@alamb
Copy link
Contributor Author

alamb commented Feb 16, 2025

I'm wondering is it possible not to run inside docker, and manually setup rust dependency, and this way we can delete some unused files and free up disk space.

Yeah, and figuring out how to reduce the disk space usage in general might be a good idea too (maybe we can make a separate binary for extended tests, for example 🤔 )

@Omega359
Copy link
Contributor

We already run with the CI profile which reduces binary size iirc.

@2010YOUY01
Copy link
Contributor

I'm wondering is it possible not to run inside docker, and manually setup rust dependency, and this way we can delete some unused files and free up disk space.

Yeah, and figuring out how to reduce the disk space usage in general might be a good idea too (maybe we can make a separate binary for extended tests, for example 🤔 )

This is a good idea to let extended tests run in a separate integration test binary.
I did a PR to fix the CI by freeing up disk spaces, which I think can also help in the long run, so perhaps this separating binary can be done as a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants