-
Notifications
You must be signed in to change notification settings - Fork 1.5k
More accurate memory accounting in external sort #14748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is a small optimization can be done after we have accurate memory accounting #15017 (comment) |
I wonder if this is ready to do now? |
Yes, I think so. However, this might cause a temporary slowdown due to an extra |
This PR actually fix memory accounting: #15700 Just need to answer the comments and add tests to prove that the memory accounting is consistent |
Is your feature request related to a problem or challenge?
#14644 fixed an external sorting bug. Each batch's memory overhead is estimated as
2 * batch memory size
for the extra row conversion overhead. It works for common cases but still can fail. See #14644 (comment) and #14644 (comment).To implement a more accurate memory size estimation for those edge cases, we can first do
col->row
conversion and measure the memory consumption. (depends on #7053)Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: