Skip to content

Consolidate SessionConfig and ConfigOptions #3887

Open
@alamb

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

While messing with thishttps://github.com//pull/3885 I found it quite confusing that SessionConfig is different than ConfigOptions and they had different ways of serializing / deserializing their values.

The new ConfigOptions was added by @andygrove #2754 and we can now see and set them via environment variables etc and are documented 🎉

https://github.com/apache/arrow-datafusion/blob/b654fdea697b9aec1cb487e292dd288e5c9d09e3/datafusion/core/src/config.rs#L235-L239

But it seems like SessionConfig is the old way and is still used (e.g. a field was just added by @Dandandan in #3846)

Describe the solution you'd like
It would be nice to unify the two (by moving all SessionConfig values into ConfigOptions)

https://github.com/apache/arrow-datafusion/blob/b654fdea697b9aec1cb487e292dd288e5c9d09e3/datafusion/core/src/execution/context.rs#L1128-L1156

Which is what I believe this comment in to_props is talking about:
https://github.com/apache/arrow-datafusion/blob/b654fdea697b9aec1cb487e292dd288e5c9d09e3/datafusion/core/src/execution/context.rs#L1282-L1289

Describe alternatives you've considered
Leave split brained as is

Additional context
#3821

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions