Fix clippy

Author: liurenjie1024

Cargo.lock

@@ -14,3 +14,4 @@ repository = { workspace = true }
 [dependencies]
 iceberg = { workspace = true }
 iceberg-catalog-rest = {workspace = true}
+tokio = { workspace = true }

crates/catalog/loader/Cargo.toml

@@ -1,16 +1,19 @@
 use std::future::Future;
+use std::pin::Pin;
 use std::sync::Arc;
 
 use iceberg::{Catalog, CatalogBuilder, Error, ErrorKind, Result};
 use iceberg_catalog_rest::RestCatalogBuilder;
 
+type BoxedCatalogBuilderFuture = Pin<Box<dyn Future<Output = Result<Arc<dyn Catalog>>>>>;
+
 pub trait BoxedCatalogBuilder {
     fn name(&mut self, name: String);
     fn uri(&mut self, uri: String);
     fn warehouse(&mut self, warehouse: String);
     fn with_prop(&mut self, key: String, value: String);
 
-    fn build(self: Box<Self>) -> Box<dyn Future<Output = Result<Arc<dyn Catalog>>>>;
+    fn build(self: Box<Self>) -> BoxedCatalogBuilderFuture;
 }
 
 impl<T: CatalogBuilder + 'static> BoxedCatalogBuilder for T {
@@ -30,9 +33,9 @@ impl<T: CatalogBuilder + 'static> BoxedCatalogBuilder for T {
         self.with_prop(key, value);
     }
 
-    fn build(self: Box<Self>) -> Box<dyn Future<Output = Result<Arc<dyn Catalog>>>> {
+    fn build(self: Box<Self>) -> BoxedCatalogBuilderFuture {
         let builder = *self;
-        Box::new(async move { Ok(Arc::new(builder.build().await.unwrap()) as Arc<dyn Catalog>) })
+        Box::pin(async move { Ok(Arc::new(builder.build().await.unwrap()) as Arc<dyn Catalog>) })
     }
 }
 
@@ -45,3 +48,17 @@ pub fn load(r#type: &str) -> Result<Box<dyn BoxedCatalogBuilder>> {
         )),
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use crate::load;
+
+    #[tokio::test]
+    async fn test_load() {
+        let mut catalog = load("rest").unwrap();
+        catalog.name("rest".to_string());
+        catalog.with_prop("key".to_string(), "value".to_string());
+
+        catalog.build().await.unwrap();
+    }
+}