Skip to content

REST catalog: support AWS sigV4 #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xxchan opened this issue Apr 23, 2025 · 5 comments · May be fixed by #1241
Open

REST catalog: support AWS sigV4 #1236

xxchan opened this issue Apr 23, 2025 · 5 comments · May be fixed by #1241
Labels
enhancement New feature or request

Comments

@xxchan
Copy link
Member

xxchan commented Apr 23, 2025

Is your feature request related to a problem or challenge?

For AWS glue/s3 tables

rest.sigv4-enabled, rest.signing-name, rest.signing-region

apache/iceberg-python#1405

rest_catalog = load_catalog(
  catalog_name,
  **{
    "type": "rest",    
    "warehouse":"arn:aws:s3tables:<Region>:<accountID>:bucket/<bucketname>",
    "uri": "https://s3tables.<Region>.amazonaws.com/iceberg",
    "rest.sigv4-enabled": "true",
    "rest.signing-name": "s3tables",
    "rest.signing-region": "<Region>"
  }
)

Describe the solution you'd like

No response

Willingness to contribute

None
@xxchan xxchan added the enhancement New feature or request label Apr 23, 2025
@xxchan
Copy link
Member Author

xxchan commented Apr 23, 2025

Found a problem in reqsign:

  1. Reqsign got canonical request like: canonical request: GET /iceberg/v1/arn%3Aaws%3As3tables%3Aap-southeast-1..., but should have been sth like /iceberg/v1/arn%253Aaws%253As3tables%253Aap-southeast-1%..., where reqsign wrongly decoded %3.
  2. x-amz-content-sha256 seems to be required for this endpoint, which is not natively supported by reqsign.

@ananthaksr
Copy link

@xxchan I'd like to work on this.

@xxchan
Copy link
Member Author

xxchan commented Apr 24, 2025

@ananthaksr Hi, thanks for offering help, but I've already finished a working draft. #1241

@xxchan xxchan linked a pull request Apr 24, 2025 that will close this issue
Open
@phillipleblanc
Copy link
Contributor

I've also implemented this in #917

@gsoundar
Copy link

gsoundar commented May 7, 2025

@xxchan How is your change coming along ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rest): support AWS SIGv4 xxchan/iceberg-rust
4 participants
@gsoundar @phillipleblanc @xxchan @ananthaksr