-
Notifications
You must be signed in to change notification settings - Fork 255
Add CatalogBuilder
trait.
#1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For pub struct CatalogConfig {
name: String,
uri: String,
warehouse: String,
props: HashMap<String, String>,
...others
} So that our CatalogLoader just need to be like: pub trait CatalogLoader {
fn load(cfg: CatalogConfig) -> Result<Arc<dyn Catalog>>;
} After this change, our loader itself is dyn compatible. Users who want to rest specific APIs can still use This change also makes it much easier for pyiceberg to connect since they can pass a What do you think? |
Sounds like a solution. Would you mind to create an example pr like #1231 so that we have a better understand what it would look like? |
No description provided.
The text was updated successfully, but these errors were encountered: