Skip to content

Add doc to explain why TableCommit 's constructor should be private. #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liurenjie1024 opened this issue Apr 27, 2025 · 0 comments · Fixed by #1263
Closed

Add doc to explain why TableCommit 's constructor should be private. #1262

liurenjie1024 opened this issue Apr 27, 2025 · 0 comments · Fixed by #1263
Assignees
@liurenjie1024
Labels
enhancement New feature or request

Comments

@liurenjie1024
Copy link
Contributor

Is your feature request related to a problem or challenge?

Currently TableCommit constructor is mark as crate private for some reason. Users not familiar with this design wants to make it public, which is error prone.

Describe the solution you'd like

No response

Willingness to contribute

None
@liurenjie1024 liurenjie1024 added the enhancement New feature or request label Apr 27, 2025
@liurenjie1024 liurenjie1024 self-assigned this Apr 27, 2025
@liurenjie1024 liurenjie1024 changed the title Add doc to explain why TableCommit should be private. Add doc to explain why TableCommit 's constructor should be private. Apr 27, 2025
@liurenjie1024 liurenjie1024 mentioned this issue Apr 27, 2025
Merged
@Xuanwo Xuanwo closed this as completed in f9061cc May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liurenjie1024 liurenjie1024

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add doc for TableCommit liurenjie1024/iceberg-rust
1 participant
@liurenjie1024