Skip to content

Rename IO traits to IcebergFileRead or IcebergRead? #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xuanwo opened this issue May 11, 2024 · 4 comments
Closed

Rename IO traits to IcebergFileRead or IcebergRead? #368

Xuanwo opened this issue May 11, 2024 · 4 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 11, 2024

          Maybe we could call this `IcebergFileRead` or `IcebergRead`? I suppose that's a bit redundant as it would be clear that it is from us by navigating to the `use` statement where it gets imported, but I'm just conscious that there are a lot of `Read` and `Write` traits dotted around and we could make it easier to see which one is ours at-a-glance where ever it is used in the future.

Originally posted by @sdd in #364 (comment)

@Xuanwo
Copy link
Member Author

Xuanwo commented May 17, 2024

cc @liurenjie1024 @Fokko, what do you think about this?

@liurenjie1024
Copy link
Contributor

To be honest I'm netural to this, is there any reason why we need to do this?

@Xuanwo
Copy link
Member Author

Xuanwo commented May 18, 2024

To be honest I'm netural to this, is there any reason why we need to do this?

I'm fine with this too. I'm going to let this issue open for more feedback.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 5, 2024

No actionable task yet, let's close.

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants