feat: Add IndexByName and IndexById to Namemapping
#1299
Conversation
There was a problem hiding this comment.
Thanks @jonathanc-n , just finished first round of review, generally looks good.
|
@jdockerty @liurenjie1024 Thanks for the reviews. Should be fixed now! |
There was a problem hiding this comment.
Thank you @jonathanc-n for working on this and thank you @liurenjie1024 for the review.
Wait for @liurenjie1024 for another look.
There was a problem hiding this comment.
Thanks @jonathanc-n for this pr, just finished second round of review. There are still some problems to fix.
| @@ -84,9 +133,187 @@ impl MappedField { | |||
| } | |||
| } | |||
|
|
|||
| /// Recursively visits the entire name mapping using visitor | |||
| fn visit_name_mapping<V>(namespace: &Vec<Arc<MappedField>>, visitor: &V) -> V::S | |||
There was a problem hiding this comment.
| fn visit_name_mapping<V>(namespace: &Vec<Arc<MappedField>>, visitor: &V) -> V::S | |
| fn visit_name_mapping<V>(namespace: &NameMapping, visitor: &V) -> V::S |
It's odd that the name is visit_name_mapping while accepts a list of fields.
There was a problem hiding this comment.
Also the return value should be a Result
There was a problem hiding this comment.
This is because when creating a new NameMapping we call visit_schema which creates an array of mapped fields which are then called on by index_by_id + index_by_name
Which issue does this PR close?
Build on #1116
What changes are included in this PR?
Adds IndexByName and index by id to name mapping
Are these changes tested?
Yes, unit tests