Remove suppressions for checkstyle MagicNumber

Author: slawekjaranowski

maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java

@@ -455,7 +455,6 @@ public DefaultRepositorySystemSession setTransferListener(TransferListener trans
         return this;
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private <T> Map<String, T> copySafe(Map<?, ?> table, Class<T> valueType) {
         Map<String, T> map;
         if (table == null || table.isEmpty()) {

maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationDigest.java

@@ -146,7 +146,6 @@ public void update(String... strings) {
      *
      * @param chars The characters to update the digest with, may be {@code null}.
      */
-    @SuppressWarnings("checkstyle:magicnumber")
     public void update(char... chars) {
         if (chars != null) {
             for (char c : chars) {
@@ -167,7 +166,6 @@ public void update(byte... bytes) {
         }
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private String digest() {
         byte[] bytes = digest.digest();
         StringBuilder buffer = new StringBuilder(bytes.length * 2);

maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/ConsoleTransferListener.java

@@ -156,7 +156,6 @@ public void transferCorrupted(TransferEvent event) {
         event.getException().printStackTrace(out);
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     protected long toKB(long bytes) {
         return (bytes + 1023) / 1024;
     }

maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/loaders/GpgAgentPasswordLoader.java

@@ -57,7 +57,6 @@
 @Singleton
 @Named(GpgAgentPasswordLoader.NAME)
 @Priority(10)
-@SuppressWarnings("checkstyle:magicnumber")
 public final class GpgAgentPasswordLoader implements GnupgSignatureArtifactGeneratorFactory.Loader {
     public static final String NAME = "agent";
     private final Logger logger = LoggerFactory.getLogger(getClass());

maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/loaders/GpgConfLoader.java

@@ -43,7 +43,6 @@
 @Singleton
 @Named(GpgConfLoader.NAME)
 @Priority(20)
-@SuppressWarnings("checkstyle:magicnumber")
 public final class GpgConfLoader implements GnupgSignatureArtifactGeneratorFactory.Loader {
     public static final String NAME = "conf";
 

maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/loaders/GpgEnvLoader.java

@@ -39,7 +39,6 @@
 @Singleton
 @Named(GpgEnvLoader.NAME)
 @Priority(30)
-@SuppressWarnings("checkstyle:magicnumber")
 public final class GpgEnvLoader implements GnupgSignatureArtifactGeneratorFactory.Loader {
     public static final String NAME = "env";
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java

@@ -148,7 +148,6 @@ private Object getMutex(Path path) {
         return path.toAbsolutePath().normalize().toString().intern();
     }
 
-    @SuppressWarnings({"checkstyle:magicnumber"})
     private FileLock fileLock(FileChannel channel, long size, boolean shared) throws IOException {
         FileLock lock = null;
         for (int attempts = 8; attempts >= 0; attempts--) {

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdatePolicyAnalyzer.java

@@ -45,7 +45,6 @@ public String getEffectiveUpdatePolicy(RepositorySystemSession session, String p
         return ordinalOfUpdatePolicy(policy1) < ordinalOfUpdatePolicy(policy2) ? policy1 : policy2;
     }
 
-    @SuppressWarnings({"checkstyle:magicnumber"})
     private int ordinalOfUpdatePolicy(String policy) {
         if (RepositoryPolicy.UPDATE_POLICY_DAILY.equals(policy)) {
             return 1440;
@@ -100,7 +99,6 @@ public boolean isUpdatedRequired(RepositorySystemSession session, long lastModif
         return checkForUpdates;
     }
 
-    @SuppressWarnings({"checkstyle:magicnumber"})
     private int getMinutes(String policy) {
         int minutes;
         try {

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/df/NodeStack.java

@@ -30,10 +30,7 @@
  */
 final class NodeStack {
 
-    @SuppressWarnings({"checkstyle:magicnumber"})
-    // CHECKSTYLE_OFF: MagicNumber
     ArrayList<DependencyNode> nodes = new ArrayList<>(96);
-    // CHECKSTYLE_ON: MagicNumber
 
     public DependencyNode top() {
         if (nodes.isEmpty()) {

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/session/DefaultSessionBuilder.java

@@ -490,7 +490,6 @@ public CloseableSession build() {
                 repositorySystemLifecycle);
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private static <T> Map<String, T> copySafe(Map<?, ?> table, Class<T> valueType) {
         Map<String, T> map;
         if (table == null || table.isEmpty()) {

maven-resolver-test-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpTransporterTest.java

@@ -78,7 +78,7 @@
 /**
  * Common set of tests against Http transporter.
  */
-@SuppressWarnings({"checkstyle:MagicNumber", "checkstyle:MethodName"})
+@SuppressWarnings({"checkstyle:MethodName"})
 public class HttpTransporterTest {
 
     protected static final Path KEY_STORE_PATH = Paths.get("target/keystore");

maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/ApacheTransporter.java

@@ -533,7 +533,6 @@ private void prepare(HttpUriRequest request, SharingHttpContext context) throws
         }
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private void mkdirs(URI uri, SharingHttpContext context) throws Exception {
         List<URI> dirs = UriUtils.getDirectories(baseUri, uri);
         int index = 0;
@@ -610,7 +609,6 @@ private <T extends HttpUriRequest> T commonHeaders(T request) {
         return request;
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private <T extends HttpUriRequest> void resume(T request, GetTask task) throws IOException {
         long resumeOffset = task.getResumeOffset();
         if (resumeOffset > 0L && task.getDataPath() != null) {
@@ -622,7 +620,6 @@ private <T extends HttpUriRequest> void resume(T request, GetTask task) throws I
         }
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private void handleStatus(CloseableHttpResponse response) throws Exception {
         int status = response.getStatusLine().getStatusCode();
         if (status >= 300) {

maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/GlobalState.java

@@ -146,7 +146,6 @@ public HttpClientConnectionManager getConnectionManager(ConnMgrConfig config) {
         return connectionManagers.computeIfAbsent(config, GlobalState::newConnectionManager);
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     public static HttpClientConnectionManager newConnectionManager(ConnMgrConfig connMgrConfig) {
         RegistryBuilder<ConnectionSocketFactory> registryBuilder = RegistryBuilder.<ConnectionSocketFactory>create()
                 .register("http", PlainConnectionSocketFactory.getSocketFactory());

maven-resolver-transport-apache/src/main/java/org/eclipse/aether/transport/apache/SharingAuthCache.java

@@ -40,7 +40,6 @@ final class SharingAuthCache implements AuthCache {
         authSchemes = new HashMap<>();
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private static HttpHost toKey(HttpHost host) {
         if (host.getPort() <= 0) {
             int port = host.getSchemeName().equalsIgnoreCase("https") ? 443 : 80;

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java

@@ -107,7 +107,6 @@
  *
  * @since 2.0.0
  */
-@SuppressWarnings({"checkstyle:magicnumber"})
 final class JdkTransporter extends AbstractTransporter implements HttpTransporter {
     private static final Logger LOGGER = LoggerFactory.getLogger(JdkTransporter.class);
 

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporterCloser.java

@@ -26,7 +26,7 @@
  * @since 2.0.0
  */
 public final class JdkTransporterCloser {
-    @SuppressWarnings("checkstyle:MagicNumber")
+
     static Runnable closer(HttpClient httpClient) {
         return () -> {
             if (httpClient instanceof AutoCloseable) {

maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-11/src/test/java/org/eclipse/aether/transport/jdk/JdkTransporterTest.java

@@ -36,7 +36,6 @@
 /**
  * JDK Transporter UT.
  */
-@SuppressWarnings({"checkstyle:magicnumber"})
 class JdkTransporterTest extends HttpTransporterTest {
 
     @Override

maven-resolver-transport-jetty/src/main/java/org/eclipse/aether/transport/jetty/PutTaskRequestContent.java

@@ -39,7 +39,6 @@ class PutTaskRequestContent extends AbstractRequestContent {
     private ByteBufferPool bufferPool;
     private boolean useDirectByteBuffers = true;
 
-    @SuppressWarnings("checkstyle:MagicNumber")
     PutTaskRequestContent(PutTask putTask) {
         this(putTask, 4096);
     }

maven-resolver-util/src/main/java/org/eclipse/aether/util/ChecksumUtils.java

@@ -148,7 +148,6 @@ private static Map<String, Object> calc(InputStream data, Collection<String> alg
      * @param bytes The bytes to represent in hex notation, may be be {@code null}.
      * @return The hexadecimal representation of the input or {@code null} if the input was {@code null}.
      */
-    @SuppressWarnings("checkstyle:magicnumber")
     public static String toHexString(byte[] bytes) {
         return StringDigestUtil.toHexString(bytes);
     }
@@ -161,7 +160,6 @@ public static String toHexString(byte[] bytes) {
      * @return The byte array of the input or {@code null} if the input was {@code null}.
      * @since 1.8.0
      */
-    @SuppressWarnings("checkstyle:magicnumber")
     public static byte[] fromHexString(String hexString) {
         return StringDigestUtil.fromHexString(hexString);
     }

maven-resolver-util/src/main/java/org/eclipse/aether/util/StringDigestUtil.java

@@ -88,7 +88,6 @@ public static String sha1(final String string) {
      * @return The hexadecimal representation of the input or {@code null} if the input was {@code null}.
      * @since 2.0.0
      */
-    @SuppressWarnings("checkstyle:magicnumber")
     public static String toHexString(byte[] bytes) {
         if (bytes == null) {
             return null;
@@ -115,7 +114,6 @@ public static String toHexString(byte[] bytes) {
      * @return The byte array of the input or {@code null} if the input was {@code null}.
      * @since 2.0.0
      */
-    @SuppressWarnings("checkstyle:magicnumber")
     public static byte[] fromHexString(String hexString) {
         if (hexString == null) {
             return null;

maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/Stack.java

@@ -29,9 +29,7 @@
 class Stack<E> extends AbstractList<E> implements RandomAccess {
 
     @SuppressWarnings("unchecked")
-    // CHECKSTYLE_OFF: MagicNumber
     private E[] elements = (E[]) new Object[96];
-    // CHECKSTYLE_ON: MagicNumber
 
     private int size;
 

maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java

@@ -71,7 +71,6 @@ private static char[] copy(char[] chars) {
         return (chars != null) ? chars.clone() : null;
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     private char[] xor(char[] chars) {
         if (chars != null) {
             int mask = System.identityHashCode(this);

maven-resolver-util/src/main/java/org/eclipse/aether/util/version/UnionVersionRange.java

@@ -137,7 +137,6 @@ public boolean equals(Object obj) {
         return ranges.equals(that.ranges);
     }
 
-    @SuppressWarnings("checkstyle:magicnumber")
     @Override
     public int hashCode() {
         return 97 * ranges.hashCode();