Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Override hint should not display for constructor #8334

Open
NReib opened this issue Mar 14, 2025 · 0 comments · May be fixed by #8338
Open

[PHP] Override hint should not display for constructor #8334

NReib opened this issue Mar 14, 2025 · 0 comments · May be fixed by #8338
Assignees
Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Milestone

Comments

@NReib
Copy link
Contributor

NReib commented Mar 14, 2025

Apache NetBeans version

Apache NetBeans 25

What happened

The following leads to a compile error in PHP - so we should not display the Add Override hint for constructors.

<?php
/**
 * @author nils
 */
class newPHPClass{

	public function __construct(){

	}
}

/**
 * @author nils
 */
class newPHPClass1 extends newPHPClass{

	#[\Override]
	public function __construct(){

	}
}

Language / Project Type / NetBeans Component

No response

How to reproduce

x

Did this work correctly in an earlier version?

No / Don't know

Operating System

Mageia

JDK

x

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

Yes

@NReib NReib added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Mar 14, 2025
@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Mar 14, 2025
@junichi11 junichi11 linked a pull request Mar 16, 2025 that will close this issue
4 tasks
@junichi11 junichi11 added this to the NB26 milestone Mar 16, 2025
@junichi11 junichi11 removed the needs:triage Requires attention from one of the committers label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants