Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE in profiler during code scan on start and or opening existing (netbeans) project #8389

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

homberghp
Copy link
Contributor

solves issue #8388

See issue.
Tiny change.

@homberghp homberghp changed the title solves issue #8388 solves issue #8388, NPE during module scan on start and or opening existing (netbeans) project Apr 2, 2025
@mbien mbien linked an issue Apr 3, 2025 that may be closed by this pull request
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) profiler labels Apr 3, 2025
@mbien mbien changed the title solves issue #8388, NPE during module scan on start and or opening existing (netbeans) project NPE in profiler during module scan on start and or opening existing (netbeans) project Apr 3, 2025
@apache apache locked and limited conversation to collaborators Apr 3, 2025
@apache apache unlocked this conversation Apr 3, 2025
@mbien mbien changed the title NPE in profiler during module scan on start and or opening existing (netbeans) project NPE in profiler during code scan on start and or opening existing (netbeans) project Apr 3, 2025
@mbien
Copy link
Member

mbien commented Apr 3, 2025

@homberghp could you update the commit message so that it reflects what the change is? No need to mention the issue, it creates just redundant links in the system. "fix possible profiler NPE during code scan" or something similar would be fine I think.

once done please do a rebase to get rid of the merge commit:

git pull --rebase --autostash https://github.com/apache/netbeans.git master

and force push into your branch:

git push -f git@github.com:homberghp/netbeans issue8388:issue8388

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be trivial.

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be just 1 commit.

@neilcsmith-net neilcsmith-net added this to the NB26 milestone Apr 8, 2025
@mbien
Copy link
Member

mbien commented Apr 8, 2025

will rebase, and merge as one commit later to get some more PRs in.

@mbien mbien merged commit ce77b5c into apache:master Apr 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java code scanning while opening project throws NPE
4 participants