From 0e27274118db76f9261021d664123b421f53e2a9 Mon Sep 17 00:00:00 2001
From: Nils Reibold <nils.reibold@aldente-it.de>
Date: Sat, 15 Mar 2025 16:48:39 +0100
Subject: [PATCH] [GH 8334] PHP do not display override hint for constructors

The following leads to a compile error in PHP - so we should not display the Add Override hint for constructors.
```php
<?php
class newPHPClass {

    public function __construct() {

    }
}

class newPHPClass1 extends newPHPClass {
    #[\Override]
    public function __construct() {
        parent::__construct();
    }
}

$anon = new class extends newPHPClass {
    #[\Override]
    public function __construct() {
        parent::__construct();
    }
};

```
---
 .../AddOverrideAttributeHint.java             |  4 ++
 .../testNoOverrideHintOnConstructor_01.php    | 39 +++++++++++++++++++
 ...p.testNoOverrideHintOnConstructor_01.hints |  0
 .../AddOverrideAttributeHintTest.java         |  4 ++
 4 files changed, 47 insertions(+)
 create mode 100644 php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php
 create mode 100644 php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php.testNoOverrideHintOnConstructor_01.hints

diff --git a/php/php.editor/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHint.java b/php/php.editor/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHint.java
index 8c6d034b84fe..521fffcfcb9e 100644
--- a/php/php.editor/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHint.java
+++ b/php/php.editor/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHint.java
@@ -159,6 +159,10 @@ private void addAddOverrideHints(CheckVisitor checkVisitor, List<Hint> hints, Ba
             if (CancelSupport.getDefault().isCancelled()) {
                 return;
             }
+            if (CodeUtils.isConstructor(method)) {
+                // Override on constructor results in compile Error (checked in PHP 8.4)
+                return;
+            }
             Identifier methodName = method.getFunction().getFunctionName();
             AddOverrideFix fix = new AddOverrideFix(document, method, ts);
             hints.add(new Hint(AddOverrideAttributeHint.this,
diff --git a/php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php b/php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php
new file mode 100644
index 000000000000..cf89481f596a
--- /dev/null
+++ b/php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php
@@ -0,0 +1,39 @@
+<?php
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+class newPHPClass {
+
+    public function __construct() {
+
+    }
+}
+
+class newPHPClass1 extends newPHPClass {
+
+    public function __construct() {
+        parent::__construct();
+    }
+}
+
+$anon = new class extends newPHPClass {
+
+    public function __construct() {
+        parent::__construct();
+    }
+};
diff --git a/php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php.testNoOverrideHintOnConstructor_01.hints b/php/php.editor/test/unit/data/testfiles/verification/AddOverrideAttributeHint/testNoOverrideHintOnConstructor_01.php.testNoOverrideHintOnConstructor_01.hints
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHintTest.java b/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHintTest.java
index 1749a679e15f..586bd9ca9ab9 100644
--- a/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHintTest.java
+++ b/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/verification/AddOverrideAttributeHintTest.java
@@ -507,6 +507,10 @@ public void testRemoveOverrideAbstractClass_Fix01() throws Exception {
         applyHint("testRemoveOverrideAbstractClass_01.php", "    #[\\Overr^ide] // test", "Remove \"#[\\Override]\" Attribute");
     }
 
+    public void testNoOverrideHintOnConstructor_01() throws Exception{
+        checkHints("testNoOverrideHintOnConstructor_01.php");
+    }
+
     private void checkHints(String fileName, PhpVersion phpVersion) throws Exception {
         checkHints(new AddOverrideAttributeHintStub(phpVersion), fileName);
     }