Skip to content

Commit f51e243

Browse files
committed
Migrate from jsr305 to jspecify and error_prone_annotations
1 parent ee67343 commit f51e243

File tree

16 files changed

+22
-20
lines changed

16 files changed

+22
-20
lines changed

Diff for: infra/common/src/main/java/org/apache/shardingsphere/infra/instance/ComputeNodeInstance.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.apache.shardingsphere.infra.state.instance.InstanceState;
2525
import org.apache.shardingsphere.infra.state.instance.InstanceStateContext;
2626

27-
import javax.annotation.concurrent.ThreadSafe;
27+
import com.google.errorprone.annotations.ThreadSafe;
2828
import java.util.Collection;
2929
import java.util.concurrent.CopyOnWriteArrayList;
3030

Diff for: infra/common/src/main/java/org/apache/shardingsphere/infra/instance/ComputeNodeInstanceContext.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.apache.shardingsphere.infra.state.instance.InstanceState;
2626
import org.apache.shardingsphere.infra.util.eventbus.EventBusContext;
2727

28-
import javax.annotation.concurrent.ThreadSafe;
28+
import com.google.errorprone.annotations.ThreadSafe;
2929
import java.util.Collection;
3030
import java.util.Optional;
3131
import java.util.Properties;

Diff for: infra/parser/src/main/java/org/apache/shardingsphere/infra/parser/cache/SQLStatementCacheLoader.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.apache.shardingsphere.sql.parser.api.CacheOption;
2424
import org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
2525

26-
import javax.annotation.ParametersAreNonnullByDefault;
26+
import org.jspecify.annotations.NullMarked;
2727

2828
/**
2929
* SQL statement cache loader.
@@ -36,7 +36,7 @@ public SQLStatementCacheLoader(final DatabaseType databaseType, final CacheOptio
3636
sqlStatementParserExecutor = new SQLStatementParserExecutor(databaseType, parseTreeCacheOption);
3737
}
3838

39-
@ParametersAreNonnullByDefault
39+
@NullMarked
4040
@Override
4141
public SQLStatement load(final String sql) {
4242
return sqlStatementParserExecutor.parse(sql);

Diff for: kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/DataConsistencyCheckUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import lombok.extern.slf4j.Slf4j;
2424
import org.apache.commons.lang3.builder.EqualsBuilder;
2525

26-
import javax.annotation.Nullable;
26+
import org.jspecify.annotations.Nullable;
2727
import java.math.BigDecimal;
2828
import java.math.BigInteger;
2929
import java.math.RoundingMode;

Diff for: kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/consistencycheck/table/calculator/SingleTableInventoryCalculateParameter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
2727
import org.apache.shardingsphere.infra.metadata.database.schema.QualifiedTable;
2828

29-
import javax.annotation.Nullable;
29+
import org.jspecify.annotations.Nullable;
3030
import java.util.Collection;
3131
import java.util.List;
3232
import java.util.concurrent.atomic.AtomicReference;

Diff for: kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/sqlbuilder/sql/PipelineDataConsistencyCalculateSQLBuilder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
2525
import org.apache.shardingsphere.infra.metadata.database.schema.QualifiedTable;
2626

27-
import javax.annotation.Nullable;
27+
import org.jspecify.annotations.Nullable;
2828
import java.util.ArrayList;
2929
import java.util.Collection;
3030
import java.util.List;

Diff for: kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/task/CDCIncrementalTask.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.apache.shardingsphere.data.pipeline.core.task.TaskExecuteCallback;
2828
import org.apache.shardingsphere.data.pipeline.core.task.progress.IncrementalTaskProgress;
2929

30-
import javax.annotation.Nullable;
30+
import org.jspecify.annotations.Nullable;
3131
import java.util.Collection;
3232
import java.util.LinkedList;
3333
import java.util.concurrent.CompletableFuture;

Diff for: kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/task/CDCInventoryTask.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import org.apache.shardingsphere.data.pipeline.core.task.TaskExecuteCallback;
3030
import org.apache.shardingsphere.data.pipeline.core.task.progress.InventoryTaskProgress;
3131

32-
import javax.annotation.Nullable;
32+
import org.jspecify.annotations.Nullable;
3333
import java.util.Collection;
3434
import java.util.Collections;
3535
import java.util.LinkedList;

Diff for: kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/planner/cache/ExecutionPlanCacheLoader.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
import com.github.benmanes.caffeine.cache.CacheLoader;
2121
import org.apache.shardingsphere.sqlfederation.optimizer.SQLFederationExecutionPlan;
2222

23-
import javax.annotation.ParametersAreNonnullByDefault;
23+
import org.jspecify.annotations.NullMarked;
2424

2525
/**
2626
* Execution plan cache loader.
2727
*/
2828
public final class ExecutionPlanCacheLoader implements CacheLoader<ExecutionPlanCacheKey, SQLFederationExecutionPlan> {
2929

30-
@ParametersAreNonnullByDefault
30+
@NullMarked
3131
@Override
3232
public SQLFederationExecutionPlan load(final ExecutionPlanCacheKey cacheKey) {
3333
return cacheKey.getSqlStatementCompiler().compile(cacheKey.getSqlStatement(), cacheKey.getDatabaseType());

Diff for: kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/PushFilterIntoScanRule.java

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
/**
3434
* Push filter into scan rule.
3535
*/
36+
@Value.Style(nullableAnnotation = "org.jspecify.annotations.Nullable", fallbackNullableAnnotation = org.jspecify.annotations.Nullable.class)
3637
@Value.Enclosing
3738
public final class PushFilterIntoScanRule extends RelRule<PushFilterIntoScanRule.Config> implements TransformationRule {
3839

Diff for: kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/planner/rule/transformation/PushProjectIntoScanRule.java

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
/**
3434
* Push project into scan rule.
3535
*/
36+
@Value.Style(nullableAnnotation = "org.jspecify.annotations.Nullable", fallbackNullableAnnotation = org.jspecify.annotations.Nullable.class)
3637
@Value.Enclosing
3738
public final class PushProjectIntoScanRule extends RelRule<PushProjectIntoScanRule.Config> implements TransformationRule {
3839

Diff for: mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContexts.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import org.apache.shardingsphere.infra.metadata.statistics.builder.ShardingSphereStatisticsFactory;
2323
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistFacade;
2424

25-
import javax.annotation.concurrent.ThreadSafe;
25+
import com.google.errorprone.annotations.ThreadSafe;
2626
import java.util.concurrent.atomic.AtomicReference;
2727

2828
/**

Diff for: parser/sql/engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/cache/ParseTreeCacheLoader.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import org.apache.shardingsphere.sql.parser.core.ParseASTNode;
2323
import org.apache.shardingsphere.sql.parser.core.database.parser.SQLParserExecutor;
2424

25-
import javax.annotation.ParametersAreNonnullByDefault;
25+
import org.jspecify.annotations.NullMarked;
2626

2727
/**
2828
* Parse context cache loader.
@@ -35,7 +35,7 @@ public ParseTreeCacheLoader(final DatabaseType databaseType) {
3535
sqlParserExecutor = new SQLParserExecutor(databaseType);
3636
}
3737

38-
@ParametersAreNonnullByDefault
38+
@NullMarked
3939
@Override
4040
public ParseASTNode load(final String sql) {
4141
return sqlParserExecutor.parse(sql);

Diff for: parser/sql/engine/src/test/java/org/apache/shardingsphere/sql/parser/api/SQLParserExecutorTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.junit.jupiter.api.Test;
2626
import org.mockito.internal.configuration.plugins.Plugins;
2727

28-
import javax.annotation.ParametersAreNonnullByDefault;
28+
import org.jspecify.annotations.NullMarked;
2929

3030
import static org.mockito.Mockito.mock;
3131
import static org.mockito.Mockito.times;
@@ -46,7 +46,7 @@ void assertParse() throws ReflectiveOperationException {
4646
LoadingCache<String, ParseASTNode> parseTreeCache = Caffeine.newBuilder().softValues().initialCapacity(128)
4747
.maximumSize(1024L).build(new CacheLoader<String, ParseASTNode>() {
4848

49-
@ParametersAreNonnullByDefault
49+
@NullMarked
5050
@Override
5151
public ParseASTNode load(final String sql) {
5252
return sqlParserExecutor.parse(sql);

Diff for: parser/sql/engine/src/test/java/org/apache/shardingsphere/sql/parser/core/SQLParserEngineTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.apache.shardingsphere.sql.parser.core.database.parser.SQLParserExecutor;
2424
import org.junit.jupiter.api.Test;
2525

26-
import javax.annotation.ParametersAreNonnullByDefault;
26+
import org.jspecify.annotations.NullMarked;
2727

2828
import static org.mockito.Mockito.mock;
2929
import static org.mockito.Mockito.when;
@@ -39,7 +39,7 @@ void assertParse() {
3939
LoadingCache<String, ParseASTNode> parseTreeCache = Caffeine.newBuilder().softValues()
4040
.initialCapacity(128).maximumSize(1024L).build(new CacheLoader<String, ParseASTNode>() {
4141

42-
@ParametersAreNonnullByDefault
42+
@NullMarked
4343
@Override
4444
public ParseASTNode load(final String sql) {
4545
return sqlParserExecutor.parse(sql);

Diff for: pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
<sonar.exclusions>**/autogen/**/*</sonar.exclusions>
6767

6868
<!-- 3rd party library versions -->
69-
<guava.version>32.1.2-jre</guava.version>
69+
<guava.version>33.4.6-jre</guava.version>
7070
<checker-qual.version>3.39.0</checker-qual.version>
7171
<error_prone_annotations.version>2.22.0</error_prone_annotations.version>
7272
<j2objc-annotations.version>1.3</j2objc-annotations.version>
@@ -119,7 +119,7 @@
119119
<commons-logging.version>1.2</commons-logging.version>
120120

121121
<lombok.version>1.18.36</lombok.version>
122-
<immutables.version>2.9.3</immutables.version>
122+
<immutables.version>2.10.1</immutables.version>
123123

124124
<postgresql.version>42.7.2</postgresql.version>
125125
<mysql-connector-java.version>8.3.0</mysql-connector-java.version>

0 commit comments

Comments
 (0)