Skip to content

Commit 2efddcf

Browse files
authored
Remove configuration debts before we release 1.0.0 (#273)
1 parent 9227b15 commit 2efddcf

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+571
-276
lines changed

.github/PULL_REQUEST_TEMPLATE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
- [ ] Update the documentation to include this new feature.
2828
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
2929
- [ ] If it's UI related, attach the screenshots below.
30+
- [ ] I have rebuilt the `Configuration.md` documentation by running `make doc-gen`
3031
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
3132

3233
<!-- ==== 📱 Remove this line WHEN AND ONLY WHEN you're adding or modifying a plugin instrumentation, follow the checklist 👇 ====

CHANGELOG.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
## Change Logs
22

33
### 1.0.0
4+
5+
- **Important Note and Breaking Changes:**
6+
- Python 3.6 is no longer supported and may not function properly.
7+
- A number of configuration options (mostly environment variables) are renamed to follow the convention of
8+
'SW_AGENT' prefixes, please check with the latest official documentation before upgrading. (#273)
9+
10+
https://skywalking.apache.org/docs/skywalking-python/v1.0.0/en/setup/configuration/
11+
- All agent core capabilities are now covered by test cases and enabled by default (Trace, Log, PVM runtime metrics, Profiler)
12+
13+
414
- Feature:
5-
- Drop support for Python 3.6
6-
- Add support for Python 3.11 (Pending)
7-
- Add MeterReportService (gRPC, Kafka reporter) (default:disabled) (#231, #236, #241, #243)
8-
- Add reporter for PVM runtime metrics (default:disabled) (#238, #247)
15+
- Add MeterReportService (gRPC, Kafka reporter) (default:enabled) (#231, #236, #241, #243)
16+
- Add reporter for PVM runtime metrics (default:enabled) (#238, #247)
917
- Add Greenlet profiler (#246)
1018
- Add test and support for Python Slim base images (#249)
1119
- Add support for the tags of Virtual Cache for Redis (#263)
@@ -29,13 +37,15 @@
2937
- Enforce tag class type conversion (#262)
3038
- Fix sw_logging (log reporter) potentially throw exception leading to traceback confusion (#267)
3139
- Avoid reporting meaningless tracecontext with logs when there's no active span, UI will now show empty traceID (#272)
40+
- Fix exception handler in profile_context (#273)
3241

3342
- Docs:
3443
- New documentation on how to test locally (#222)
3544
- New documentation on the newly added meter reporter feature (#240)
3645
- New documentation on the newly added greenlet profiler and the original threading profiler (#250)
3746
- Overhaul documentation on development setup and testing (#249)
3847
- Add tables to state currently supported features of Python agent. (#271)
48+
- New configuration documentation generator (#273)
3949

4050
- Others:
4151
- Pin CI SkyWalking License Eye (#221)

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ fix:
7878
.PHONY: doc-gen
7979
doc-gen: gen
8080
poetry run python3 tools/plugin_doc_gen.py
81+
poetry run python3 tools/config_doc_gen.py
8182

8283
.PHONY: check-doc-gen
8384
check-doc-gen: doc-gen

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121

2222
## Capabilities
2323

24-
| Reporter | Supported? | Details |
25-
|:----------|:-----------------|:-----------------------------------------------------------|
26-
| Trace | ✅ (default: ON) | Automatic instrumentation + Manual SDK |
27-
| Log | ✅ (default: OFF) | Direct reporter only. (Tracing context in log planned) |
28-
| Meter | ✅ (default: ON) | Meter API + Automatic PVM metrics |
29-
| Event | ❌ (Planned) | Report lifecycle events of your awesome Python application |
30-
| Profiling | ✅ (default: ON) | Threading and Greenlet Profiler |
24+
| Reporter | Supported? | Details |
25+
|:----------|:----------------|:-----------------------------------------------------------|
26+
| Trace | ✅ (default: ON) | Automatic instrumentation + Manual SDK |
27+
| Log | ✅ (default: ON) | Direct reporter only. (Tracing context in log planned) |
28+
| Meter | ✅ (default: ON) | Meter API + Automatic PVM metrics |
29+
| Event | ❌ (Planned) | Report lifecycle events of your awesome Python application |
30+
| Profiling | ✅ (default: ON) | Threading and Greenlet Profiler |
3131

3232
## Installation Requirements
3333

docs/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ This documentation covers a number of ways to set up the Python agent for variou
1717

1818
The following table demonstrates the currently supported telemetry collection capabilities in SkyWalking Python agent:
1919

20-
| Reporter | Supported? | Details |
21-
|:----------|:-----------------|:-----------------------------------------------------------|
22-
| Trace | ✅ (default: ON) | Automatic instrumentation + Manual SDK |
23-
| Log | ✅ (default: OFF) | Direct reporter only. (Tracing context in log planned) |
24-
| Meter | ✅ (default: ON) | Meter API + Automatic PVM metrics |
25-
| Event | ❌ (Planned) | Report lifecycle events of your awesome Python application |
26-
| Profiling | ✅ (default: ON) | Threading and Greenlet Profiler |
20+
| Reporter | Supported? | Details |
21+
|:----------|:----------------|:-----------------------------------------------------------|
22+
| Trace | ✅ (default: ON) | Automatic instrumentation + Manual SDK |
23+
| Log | ✅ (default: ON) | Direct reporter only. (Tracing context in log planned) |
24+
| Meter | ✅ (default: ON) | Meter API + Automatic PVM metrics |
25+
| Event | ❌ (Planned) | Report lifecycle events of your awesome Python application |
26+
| Profiling | ✅ (default: ON) | Threading and Greenlet Profiler |
2727

2828

2929
## Live Demo

docs/en/contribution/How-to-develop-plugin.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ You can always take [the existing plugins](../setup/Plugins.md) as examples, whi
2020
```
2121
4. Every plugin requires a corresponding test under `tests/plugin` before it can be merged, refer to the [Plugin Test Guide](How-to-test-plugin.md) when writing a plugin test.
2222
5. Update the [Supported Plugin List](../setup/Plugins.md).
23-
6. Add the environment variables to [Environment Variable list](../setup/EnvVars.md) if any.
23+
6. Add the environment variables to [Environment Variable list](../setup/Configuration.md) if any.
2424

2525
## Steps after coding
2626

docs/en/setup/CLI.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Sometimes you don't actually need the agent to monitor anything in a child proce
5050

5151
If you do not need the agent to get loaded for application child processes, you can turn off the behavior by setting an environment variable.
5252

53-
`SW_PYTHON_BOOTSTRAP_PROPAGATE` to `False`
53+
`SW_AGENT_SW_PYTHON_BOOTSTRAP_PROPAGATE` to `False`
5454

5555
Note the auto bootstrap depends on the environment inherited by child processes,
5656
thus prepending a new sitecustomize path to or removing the loader path from the `PYTHONPATH` could prevent the agent from loading in a child process.
@@ -62,7 +62,7 @@ You would normally want to provide additional configurations other than the defa
6262
#### Through environment variables
6363

6464
The currently supported method is to provide the environment variables listed
65-
and explained in the [Environment Variables List](EnvVars.md).
65+
and explained in the [Environment Variables List](Configuration.md).
6666

6767
#### Through a sw-config.yaml
6868

0 commit comments

Comments
 (0)