-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Tabs): Upgrade Tabs to Antd5 #32810
refactor(Tabs): Upgrade Tabs to Antd5 #32810
Conversation
…to alexandrusoare/refactor/antd5-tabs
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
…to alexandrusoare/refactor/antd5-tabs
…to alexandrusoare/refactor/antd5-tabs
…to alexandrusoare/refactor/antd5-tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/src/dashboard/util/getChartAndLabelComponentIdFromPath.js | ✅ |
superset-frontend/src/dashboard/components/DashboardBuilder/utils.ts | ✅ |
superset-frontend/packages/superset-ui-core/src/theme/GlobalStyles.tsx | ✅ |
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx | ✅ |
superset-frontend/src/components/Chart/DrillBy/useResultsTableView.tsx | ✅ |
superset-frontend/src/components/Tabs/Tabs.stories.tsx | ✅ |
superset-frontend/src/dashboard/styles.ts | ✅ |
superset-frontend/src/features/datasets/AddDataset/EditDataset/index.tsx | ✅ |
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx | ✅ |
superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigPopover.tsx | ✅ |
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx | ✅ |
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx | ✅ |
superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx | ✅ |
superset-frontend/src/SqlLab/components/App/index.tsx | ✅ |
superset-frontend/src/components/Tabs/Tabs.tsx | ✅ |
superset-frontend/src/SqlLab/components/SouthPane/index.tsx | ✅ |
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx | ✅ |
superset-frontend/src/components/Modal/Modal.tsx | ✅ |
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx | ✅ |
superset-frontend/src/components/Datasource/DatasourceModal.tsx | ✅ |
superset-frontend/src/SqlLab/components/TablePreview/index.tsx | ✅ |
superset-frontend/src/explore/components/ExploreChartPanel/index.jsx | ✅ |
superset-frontend/src/features/databases/DatabaseModal/styles.ts | ✅ |
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx | ✅ |
superset-frontend/src/explore/components/ControlPanelsContainer.tsx | ✅ |
superset-frontend/cypress-base/cypress/support/directories.ts | ✅ |
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | ✅ |
superset-frontend/src/components/Datasource/DatasourceEditor.jsx | ✅ |
superset-frontend/src/features/databases/DatabaseModal/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
❤️ ❤️ ❤️! - dark mode starting to look really solid, after Looking forward to rip out all of the |
Fixes #32620
SUMMARY
Upgraded Tabs to Antd5
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE WITH LIGHT THEME

AFTER WITH LIGHT THEME

BEFORE WITH DARK THEME

AFTER WITH DARK THEME

BEFORE WITH LIGHT THEME

AFTER WITH LIGHT THEME

BEFORE WITH DARK THEME

AFTER WITH DARK THEME

BEFORE WITH LIGHT THEME

AFTER WITH LIGHT THEME

BEFORE WITH DARK THEME

AFTER WITH DARK THEME

TESTING INSTRUCTIONS
ADDITIONAL INFORMATION