Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Tabs): Upgrade Tabs to Antd5 #32810

Merged

Conversation

alexandrusoare
Copy link
Contributor

@alexandrusoare alexandrusoare commented Mar 23, 2025

Fixes #32620

SUMMARY

Upgraded Tabs to Antd5

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE WITH LIGHT THEME
image

AFTER WITH LIGHT THEME
image

BEFORE WITH DARK THEME
image

AFTER WITH DARK THEME
image

BEFORE WITH LIGHT THEME
image

AFTER WITH LIGHT THEME
image

BEFORE WITH DARK THEME
image

AFTER WITH DARK THEME
image

BEFORE WITH LIGHT THEME
image

AFTER WITH LIGHT THEME
image

BEFORE WITH DARK THEME
image

AFTER WITH DARK THEME
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Mar 23, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@alexandrusoare alexandrusoare changed the title Alexandrusoare/refactor/antd5 tabs refactor(Tabs): Upgrade Tabs to Antd5 Mar 23, 2025
@geido geido added hold! On hold preset:bounty Issues that have been selected by Preset and have a bounty attached. frontend:refactor:antd5 labels Mar 24, 2025
@alexandrusoare alexandrusoare marked this pull request as ready for review April 7, 2025 12:45
@dosubot dosubot bot added the frontend:refactor Related to refactoring the frontend label Apr 7, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/dashboard/util/getChartAndLabelComponentIdFromPath.js
superset-frontend/src/dashboard/components/DashboardBuilder/utils.ts
superset-frontend/packages/superset-ui-core/src/theme/GlobalStyles.tsx
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx
superset-frontend/src/components/Chart/DrillBy/useResultsTableView.tsx
superset-frontend/src/components/Tabs/Tabs.stories.tsx
superset-frontend/src/dashboard/styles.ts
superset-frontend/src/features/datasets/AddDataset/EditDataset/index.tsx
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigPopover.tsx
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx
superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx
superset-frontend/src/SqlLab/components/App/index.tsx
superset-frontend/src/components/Tabs/Tabs.tsx
superset-frontend/src/SqlLab/components/SouthPane/index.tsx
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx
superset-frontend/src/components/Modal/Modal.tsx
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
superset-frontend/src/components/Datasource/DatasourceModal.tsx
superset-frontend/src/SqlLab/components/TablePreview/index.tsx
superset-frontend/src/explore/components/ExploreChartPanel/index.jsx
superset-frontend/src/features/databases/DatabaseModal/styles.ts
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
superset-frontend/src/explore/components/ControlPanelsContainer.tsx
superset-frontend/cypress-base/cypress/support/directories.ts
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
superset-frontend/src/components/Datasource/DatasourceEditor.jsx
superset-frontend/src/features/databases/DatabaseModal/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@geido geido removed the hold! On hold label Apr 7, 2025
@geido geido merged commit 33febb6 into apache:template_less Apr 7, 2025
66 of 82 checks passed
@mistercrunch
Copy link
Member

mistercrunch commented Apr 7, 2025

❤️ ❤️ ❤️! - dark mode starting to look really solid, after <Select /> and <Collapse /> there wont be much standing in the way of theming. Nice.

Looking forward to rip out all of the .less. LESS IS MORE takes all it's meaning here :)

@mistercrunch
Copy link
Member

Reporting a visual glitch here where padding isn't right around tabs.
Screenshot 2025-04-07 at 2 45 42 PM

Wondering where the padding belongs, probably in the modal content, and if it's added there probably should be removed from the tab's body so it's not double-padded (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:refactor:antd5 frontend:refactor Related to refactoring the frontend packages preset:bounty Issues that have been selected by Preset and have a bounty attached. review:draft size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants