Skip to content

Commit 613f1fb

Browse files
committed
Merge rust-bitcoin#2792: Header change from arguments to parameters
9bb7570 Header change from arguments to parameters (jamil.lambert) Pull request description: In a few cases a function header documents the parameters of the following function under the heading "Arguments", this has been changed to "Parameters". Since the description is at the level of the function definition and not where it is being called parameters seems the more accurate term. ACKs for top commit: apoelstra: ACK 9bb7570 tcharding: ACK 9bb7570 Tree-SHA512: aa24af3fd6e086c09f5e2605fa58289969fc7188f63d7f53c0e325315644f9704d51d4cf526ebfc51b2cf9216155fc3d48cc6bca759dc14bae15e4770de5116e
2 parents 1142d16 + 9bb7570 commit 613f1fb

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

bitcoin/examples/sighash.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use hex_lit::hex;
1313

1414
/// Computes segwit sighash for a transaction input that spends a p2wpkh output with "witness_v0_keyhash" scriptPubKey.type
1515
///
16-
/// # Arguments
16+
/// # Parameters
1717
///
1818
/// * `raw_tx` - spending tx hex
1919
/// * `inp_idx` - spending tx input index
@@ -52,7 +52,7 @@ fn compute_sighash_p2wpkh(raw_tx: &[u8], inp_idx: usize, value: u64) {
5252

5353
/// Computes sighash for a legacy multisig transaction input that spends either a p2sh or a p2ms output.
5454
///
55-
/// # Arguments
55+
/// # Parameters
5656
///
5757
/// * `raw_tx` - spending tx hex
5858
/// * `inp_idx` - spending tx input inde
@@ -98,7 +98,7 @@ fn compute_sighash_legacy(raw_tx: &[u8], inp_idx: usize, script_pubkey_bytes_opt
9898

9999
/// Computes sighash for a segwit multisig transaction input that spends a p2wsh output with "witness_v0_scripthash" scriptPubKey.type
100100
///
101-
/// # Arguments
101+
/// # Parameters
102102
///
103103
/// * `raw_tx` - spending tx hex
104104
/// * `inp_idx` - spending tx input index

bitcoin/src/blockdata/transaction.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,7 +1303,7 @@ impl From<&Transaction> for Wtxid {
13031303
/// a [`TxOut`] when adding another [`TxOut`] to the transaction. This happens when the new
13041304
/// [`TxOut`] added causes the output length `VarInt` to increase its encoding length.
13051305
///
1306-
/// # Arguments
1306+
/// # Parameters
13071307
///
13081308
/// * `fee_rate` - the fee rate of the transaction being created.
13091309
/// * `satisfaction_weight` - satisfied spending conditions weight.
@@ -1322,7 +1322,7 @@ pub fn effective_value(
13221322
/// This function computes the weight of a transaction which is not fully known. All that is needed
13231323
/// is the lengths of scripts and witness elements.
13241324
///
1325-
/// # Arguments
1325+
/// # Parameters
13261326
///
13271327
/// * `inputs` - an iterator which returns `InputWeightPrediction` for each input of the
13281328
/// to-be-constructed transaction.

internals/src/error/parse_error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
/// The resulting type is public, conditionally implements `std::error::Error` and has a private
1010
/// `new()` method for convenience.
1111
///
12-
/// ## Parameters
12+
/// # Parameters
1313
///
1414
/// * `name` - the name of the error type
1515
/// * `source` - the type of the source type

0 commit comments

Comments
 (0)