Skip to content

Changed 'Create Successfully' to 'Created Successfully #5369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025

Conversation

jagrutatwork
Copy link
Contributor

@jagrutatwork jagrutatwork commented Mar 27, 2025

What's the purpose of this PR
Fixed a minor spelling mistake in apollo-portal/src/main/resources/static/i18n/en.json. No functional changes.

Which issue(s) this PR fixes:
Fixes #5368

Brief changelog
Changed 'Create Successfully' to 'Created Successfully'

Summary by CodeRabbit

  • Style
    • Updated the cluster creation confirmation message to "Created successfully" for clearer communication regarding action completion.
    • Standardized verb tense in localization strings for consistency across the Apollo portal.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

coderabbitai bot commented Mar 27, 2025

Walkthrough

The English localization file for the Apollo portal has been updated to change the verb tense for success messages related to cluster creation. The text has been modified from "Create Successfully" to "Created Successfully" for consistency. No other changes to declarations or functionality were made.

Changes

File Change Summary
apollo-portal/src/.../en.json Updated success message text from "Create Successfully" to "Created Successfully" and "Create cluster successfully" to "Created cluster successfully".

Assessment against linked issues

Objective Addressed Explanation
[#5368] Text on cluster creation should be "Created Successfully"

Poem

I'm a happy rabbit, hopping along the code trail,
Changing words with a twitch and a tail,
The past tense now hops in every line,
Yet "cluster" lingers where it might refine,
With keen eyes I nibble on what’s new and bright,
Celebrating in ASCII hops under the moonlight.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61dfd54 and 3569140.

📒 Files selected for processing (1)
  • apollo-portal/src/main/resources/static/i18n/en.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apollo-portal/src/main/resources/static/i18n/en.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagrutatwork
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jagrutatwork
Copy link
Contributor Author

@lonre @tianzhou @nobodyiam Can someone please review this?

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2025
@nobodyiam nobodyiam merged commit 33318b0 into apolloconfig:master Apr 10, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text appearing after a cluster is created should be 'Created Successfully'.
2 participants