Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

Commit a579abf

Browse files
committed
Remove rest of time-trace message as it is inconsistent style
Other options which create output files don't produce output messages. Improve documentation to help find trace file. Differential Revision: https://reviews.llvm.org/D68710 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@374294 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 414670b commit a579abf

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

include/clang/Driver/Options.td

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1791,7 +1791,12 @@ def : Flag<["-"], "fterminated-vtables">, Alias<fapple_kext>;
17911791
def fthreadsafe_statics : Flag<["-"], "fthreadsafe-statics">, Group<f_Group>;
17921792
def ftime_report : Flag<["-"], "ftime-report">, Group<f_Group>, Flags<[CC1Option]>;
17931793
def ftime_trace : Flag<["-"], "ftime-trace">, Group<f_Group>,
1794-
HelpText<"Turn on time profiler">, Flags<[CC1Option, CoreOption]>;
1794+
HelpText<"Turn on time profiler. Generates JSON file based on output filename.">,
1795+
DocBrief<[{
1796+
Turn on time profiler. Generates JSON file based on output filename. Results
1797+
can be analyzed with chrome://tracing or `Speedscope App
1798+
<https://www.speedscope.app>`_ for flamegraph visualization.}]>,
1799+
Flags<[CC1Option, CoreOption]>;
17951800
def ftime_trace_granularity_EQ : Joined<["-"], "ftime-trace-granularity=">, Group<f_Group>,
17961801
HelpText<"Minimum time granularity (in microseconds) traced by time profiler">,
17971802
Flags<[CC1Option, CoreOption]>;

tools/driver/cc1_main.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,6 @@ int cc1_main(ArrayRef<const char *> Argv, const char *Argv0, void *MainAddr) {
269269
// FIXME(ibiryukov): make profilerOutput flush in destructor instead.
270270
profilerOutput->flush();
271271
llvm::timeTraceProfilerCleanup();
272-
273-
llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n";
274272
}
275273
}
276274

0 commit comments

Comments
 (0)