Skip to content

Commit 47f9eab

Browse files
btsghbtsgh
authored
Merge pull request #39555 from appsmithorg/release
05/03 Daily Promotion
2 parents b4e674d + 320b168 commit 47f9eab

File tree

741 files changed

+4366
-2360
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

741 files changed

+4366
-2360
lines changed

‎.github/ISSUE_TEMPLATE/--bug-report.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ body:
7272
id: video
7373
attributes:
7474
label: Issue video log
75-
description: "Share a loom video recording of how the issue can be reporduced"
75+
description: "Share a loom video recording of how the issue can be reproduced"
7676
placeholder: "https://www.loom.com/share/d54e04bc68e24798..."
7777
validations:
7878
required: false

‎CODEOWNERS

+64-58
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
44
# Followed Globstar paths in combination with wildcard paths. Reference https://docs.gitlab.com/ee/user/project/codeowners/reference.html#globstar-paths
55

6-
app/client/.husky @KelvinOm
7-
app/client/.yarn @KelvinOm
6+
# Some paths highlighted as not existing. This may be due to the fact that we use same file for EE repo as well.
7+
# Before deleting, make sure that the path does not really exist.
8+
9+
app/client/.husky/** @KelvinOm
10+
app/client/.yarn/** @KelvinOm
811
app/client/.editorconfig @KelvinOm
912
app/client/.eslintrc.base.json @KelvinOm
1013
app/client/.eslintrc.js @KelvinOm
@@ -15,28 +18,71 @@ app/client/.prettierignore @KelvinOm
1518
app/client/.prettierrc @KelvinOm
1619
app/client/.yarnrc.yml @KelvinOm
1720
app/client/jest.config.js @KelvinOm
21+
app/client/knip.json @KelvinOm
1822
app/client/package.json @KelvinOm
1923
app/client/tsconfig.json @KelvinOm
2024
app/client/tsconfig.path.json @KelvinOm
21-
22-
# WDS team
23-
app/client/packages/design-system/* @appsmithorg/wds-team
24-
app/client/packages/storybook/* @appsmithorg/wds-team
25-
app/client/src/widgets/wds/* @appsmithorg/wds-team @appsmithorg/anvil-team
26-
27-
# Anvil-team
28-
app/client/src/layoutSystems/anvil/* @appsmithorg/anvil-team
25+
app/client/packages/utils/** @KelvinOm
26+
app/client/packages/eslint-plugin/** @KelvinOm
27+
app/client/config/** @KelvinOm @alex-golovanov @riodeuno
28+
app/client/scripts/** @KelvinOm @alex-golovanov @riodeuno
2929

3030
# App viewers pod
31-
app/client/src/widgets/* @appsmithorg/widgets-blocks
32-
app/client/src/components/propertyControls/* @appsmithorg/widgets-blocks
31+
app/client/src/widgets/** @appsmithorg/widgets-blocks
32+
app/client/src/components/propertyControls/** @appsmithorg/widgets-blocks
3333
app/client/src/sagas/OneClickBindingSaga.ts @appsmithorg/widgets-blocks
34-
app/client/src/WidgetQueryGenerators/* @appsmithorg/widgets-blocks
35-
app/client/src/components/editorComponents/WidgetQueryGeneratorForm/* @appsmithorg/widgets-blocks
36-
app/client/src/pages/AppViewer/* @appsmithorg/widgets-blocks
34+
app/client/src/WidgetQueryGenerators/** @appsmithorg/widgets-blocks
35+
app/client/src/components/editorComponents/WidgetQueryGeneratorForm/** @appsmithorg/widgets-blocks
36+
app/client/src/pages/AppViewer/** @appsmithorg/widgets-blocks
37+
38+
# AI Agents POD
39+
# AI Agents FE
40+
app/client/src/widgets/wds/** @appsmithorg/ai-agents-fe
41+
app/client/src/ee/widgets/wds/** @appsmithorg/ai-agents-fe
42+
app/client/packages/carbon-connect/** @appsmithorg/ai-agents-fe
43+
app/client/generators/** @appsmithorg/ai-agents-fe
44+
app/client/src/actions/canvasSelectionActions.ts @appsmithorg/ai-agents-fe
45+
app/client/src/actions/reflowActions.ts @appsmithorg/ai-agents-fe
46+
app/client/src/actions/widgetSelectionActions.ts @appsmithorg/ai-agents-fe
47+
app/client/src/layoutSystems/anvil/** @appsmithorg/ai-agents-fe
48+
app/client/src/pages/Editor/Canvas.tsx @appsmithorg/ai-agents-fe
49+
app/client/src/pages/Editor/CanvasLayoutConversion/** @appsmithorg/ai-agents-fe
50+
app/client/src/pages/Editor/PropertyPane/** @appsmithorg/ai-agents-fe
51+
app/client/src/pages/Editor/WidgetsEditor/** @appsmithorg/ai-agents-fe
52+
app/client/src/reducers/entityReducers/autoHeightReducers/** @appsmithorg/ai-agents-fe
53+
app/client/src/reflow/** @appsmithorg/ai-agents-fe
54+
app/client/src/sagas/CanvasSagas/** @appsmithorg/ai-agents-fe
55+
app/client/src/sagas/ReplaySaga.ts @appsmithorg/ai-agents-fe
56+
app/client/src/sagas/SnapshotSagas.ts @appsmithorg/ai-agents-fe
57+
app/client/src/sagas/WidgetAdditionSagas.ts @appsmithorg/ai-agents-fe
58+
app/client/src/sagas/WidgetBlueprintSagas.ts @appsmithorg/ai-agents-fe
59+
app/client/src/sagas/WidgetDeletionSagas.ts @appsmithorg/ai-agents-fe
60+
app/client/src/sagas/WidgetOperationSagas.tsx @appsmithorg/ai-agents-fe
61+
app/client/src/sagas/WidgetOperationUtils.ts @appsmithorg/ai-agents-fe
62+
app/client/src/sagas/WidgetSelectUtils.ts @appsmithorg/ai-agents-fe
63+
app/client/src/sagas/WidgetSelectionSagas.ts @appsmithorg/ai-agents-fe
64+
app/client/src/sagas/layoutConversionSagas.ts @appsmithorg/ai-agents-fe
65+
app/client/src/selectors/canvasSelectors.ts @appsmithorg/ai-agents-fe
66+
app/client/src/selectors/widgetSelectors.ts @appsmithorg/ai-agents-fe
67+
app/client/src/utils/hooks/useAllowEditorDragToSelect.ts @appsmithorg/ai-agents-fe
68+
app/client/src/utils/hooks/useClickToSelectWidget.tsx @appsmithorg/ai-agents-fe
69+
app/client/src/utils/hooks/usePositionedContainerZIndex.ts @appsmithorg/ai-agents-fe
70+
app/client/src/utils/hooks/useReflow.ts @appsmithorg/ai-agents-fe
71+
app/client/src/utils/hooks/useWidgetSelection.ts @appsmithorg/ai-agents-fe
72+
73+
# # AI Agents BE
74+
app/client/packages/rts/src/chat/** @appsmithorg/ai-agents-be
75+
app/server/**/appsmith-ai/** @appsmithorg/ai-agents-be
76+
app/server/**/ai/** @appsmithorg/ai-agents-be
77+
/app/server/appsmith-plugins/appsmithAiPlugin/** @appsmithorg/ai-agents-be
78+
79+
# WDS team is part of AI Agents POD and responsible for widget design system
80+
app/client/packages/design-system/** @appsmithorg/wds-team
81+
app/client/packages/storybook/** @appsmithorg/wds-team
82+
app/client/packages/icons/** @appsmithorg/wds-team
3783

3884
# New Developers Pod
39-
app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/* @nilanshbansal
85+
app/server/appsmith-server/src/main/java/com/appsmith/server/featureflags/** @nilanshbansal
4086
app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserIdentifierService.java @nilanshbansal
4187
app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserIdentifierServiceImpl.java @nilanshbansal
4288
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/UserIdentifierServiceCE.java @nilanshbansal
@@ -52,46 +98,6 @@ app/server/appsmith-server/src/main/java/com/appsmith/server/services/FeatureFla
5298
app/server/appsmith-server/src/main/java/com/appsmith/server/services/FeatureFlagServiceImpl.java @nilanshbansal
5399
app/server/appsmith-server/src/test/java/com/appsmith/server/services/FeatureFlagServiceTest.java @nilanshbansal
54100

55-
# UI Builders Pod
56-
app/client/generators/* @appsmithorg/anvil-team
57-
app/client/src/actions/canvasSelectionActions.ts @appsmithorg/anvil-team
58-
app/client/src/actions/reflowActions.ts @appsmithorg/anvil-team
59-
app/client/src/actions/widgetSelectionActions.ts @appsmithorg/anvil-team
60-
app/client/src/components/propertyControls/* @appsmithorg/anvil-team
61-
app/client/src/layoutSystems/anvil/* @appsmithorg/anvil-team
62-
app/client/src/pages/Editor/Canvas.tsx @appsmithorg/anvil-team
63-
app/client/src/pages/Editor/CanvasLayoutConversion/* @appsmithorg/anvil-team
64-
app/client/src/pages/Editor/PropertyPane/* @appsmithorg/anvil-team
65-
app/client/src/pages/Editor/WidgetsEditor/* @appsmithorg/anvil-team
66-
app/client/src/reducers/entityReducers/autoHeightReducers/* @appsmithorg/anvil-team
67-
app/client/src/reducers/entityReducers/canvasWidgetsReducer.ts @appsmithorg/anvil-team
68-
app/client/src/reflow/* @appsmithorg/anvil-team
69-
app/client/src/sagas/CanvasSagas/* @appsmithorg/anvil-team
70-
app/client/src/sagas/ReplaySaga.ts @appsmithorg/anvil-team
71-
app/client/src/sagas/SnapshotSagas.ts @appsmithorg/anvil-team
72-
app/client/src/sagas/WidgetAdditionSagas.ts @appsmithorg/anvil-team
73-
app/client/src/sagas/WidgetBlueprintSagas.ts @appsmithorg/anvil-team
74-
app/client/src/sagas/WidgetDeletionSagas.ts @appsmithorg/anvil-team
75-
app/client/src/sagas/WidgetOperationSagas.tsx @appsmithorg/anvil-team
76-
app/client/src/sagas/WidgetOperationUtils.ts @appsmithorg/anvil-team
77-
app/client/src/sagas/WidgetSelectUtils.ts @appsmithorg/anvil-team
78-
app/client/src/sagas/WidgetSelectionSagas.ts @appsmithorg/anvil-team
79-
app/client/src/sagas/layoutConversionSagas.ts @appsmithorg/anvil-team
80-
app/client/src/selectors/canvasSelectors.ts @appsmithorg/anvil-team
81-
app/client/src/selectors/widgetSelectors.ts @appsmithorg/anvil-team
82-
app/client/src/utils/hooks/useAllowEditorDragToSelect.ts @appsmithorg/anvil-team
83-
app/client/src/utils/hooks/useClickToSelectWidget.tsx @appsmithorg/anvil-team
84-
app/client/src/utils/hooks/useDynamicAppLayout.tsx @appsmithorg/anvil-team
85-
app/client/src/utils/hooks/usePositionedContainerZIndex.ts @appsmithorg/anvil-team
86-
app/client/src/utils/hooks/useReflow.ts @appsmithorg/anvil-team
87-
app/client/src/utils/hooks/useWidgetSelection.ts @appsmithorg/anvil-team
88-
app/client/src/widgets/BaseWidget.tsx @appsmithorg/anvil-team
89-
app/client/src/widgets/BaseWidgetHOC/* @appsmithorg/anvil-team
90-
app/client/src/widgets/CanvasWidget.tsx @appsmithorg/anvil-team
91-
app/client/src/widgets/ContainerWidget/* @appsmithorg/anvil-team
92-
app/client/src/widgets/MetaHOC.tsx @appsmithorg/anvil-team
93-
app/client/src/widgets/withWidgetProps.tsx @appsmithorg/anvil-team
94-
95101
# Git Pod
96102
app/server/appsmith-git/ @appsmithorg/git-be-reviewers
97103
app/server/**/git/** @appsmithorg/git-be-reviewers
@@ -122,8 +128,8 @@ app/client/src/components/formControls/utils.ts @ayushpahwa
122128
app/client/src/entities/Datasource/index.ts @ayushpahwa
123129
app/client/src/entities/FeatureFlags.ts @ayushpahwa
124130
app/client/src/navigation/FocusEntity.ts @ayushpahwa
125-
app/client/src/pages/Editor/APIEditor/* @ayushpahwa
126-
app/client/src/pages/Editor/DataSourceEditor/* @ayushpahwa
131+
app/client/src/pages/Editor/APIEditor/** @ayushpahwa
132+
app/client/src/pages/Editor/DataSourceEditor/** @ayushpahwa
127133
app/client/src/pages/Editor/IntegrationEditor/DatasourceCard.tsx @ayushpahwa
128134
app/client/src/pages/Editor/IntegrationEditor/IntegrationsHomeScreen.tsx @ayushpahwa
129135
app/client/src/pages/Editor/IntegrationEditor/NewApi.tsx @ayushpahwa

‎app/client/cypress/support/Pages/Anvil/Locators/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { MAIN_CONTAINER_WIDGET_ID } from "../../../../../src/constants/WidgetConstants";
22
import { getAnvilCanvasId } from "../../../../../src/layoutSystems/anvil/viewer/canvas/utils";
3-
import { AnvilDataAttributes } from "../../../../../src/modules/ui-builder/ui/wds/constants";
3+
import { AnvilDataAttributes } from "../../../../../src/widgets/wds/constants";
44

55
// anvil widget based selectors
66
const anvilWidgetSelector = "[data-testid=t--anvil-widget-wrapper]";

‎app/client/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306
"babel-plugin-module-resolver": "^4.1.0",
307307
"babel-plugin-named-asset-import": "^0.3.8",
308308
"babel-preset-react-app": "^10.0.1",
309-
"browserslist": "^4.18.1",
309+
"browserslist": "^4.24.4",
310310
"case-sensitive-paths-webpack-plugin": "^2.4.0",
311311
"chalk": "^4.1.1",
312312
"compression-webpack-plugin": "^10.0.0",
@@ -399,7 +399,7 @@
399399
"xlsx": "https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz"
400400
},
401401
"resolutions": {
402-
"browserslist": "4.20.3",
402+
"browserslist": "4.24.4",
403403
"chokidar": "3.5.3",
404404
"css-select": "4.1.3",
405405
"ejs": "3.1.10",

‎app/client/packages/design-system/ads/src/Templates/EditableDismissibleTab/EditableDismissibleTab.tsx

+8-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { DismissibleTab } from "../../DismissibleTab";
66
import { EditableEntityName } from "../EditableEntityName";
77

88
import type { EditableDismissibleTabProps } from "./EditableDismissibleTab.types";
9+
import { useActiveDoubleClick } from "../../__hooks__";
910

1011
export const EditableDismissibleTab = (props: EditableDismissibleTabProps) => {
1112
const {
@@ -33,7 +34,13 @@ export const EditableDismissibleTab = (props: EditableDismissibleTabProps) => {
3334
const isEditing = propIsEditing ?? localIsEditing;
3435
const handleEnterEditMode = propOnEnterEditMode ?? localOnEnterEditMode;
3536
const handleExitEditMode = propOnExitEditMode ?? localOnExitEditMode;
36-
const handleDoubleClick = isEditable ? handleEnterEditMode : noop;
37+
38+
const doubleClickOverride = useActiveDoubleClick(
39+
isActive,
40+
handleEnterEditMode,
41+
);
42+
43+
const handleDoubleClick = isEditable ? doubleClickOverride : noop;
3744

3845
return (
3946
<DismissibleTab

‎app/client/packages/design-system/ads/src/Templates/EntityExplorer/EntityItem/EntityItem.tsx

+9-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,16 @@ import { ListItem } from "../../../List";
33
import type { EntityItemProps } from "./EntityItem.types";
44
import clx from "classnames";
55
import { EditableEntityName } from "../../EditableEntityName";
6+
import { useActiveDoubleClick } from "../../../__hooks__";
67

78
export const EntityItem = (props: EntityItemProps) => {
9+
const { onDoubleClick, startIcon, ...rest } = props;
10+
11+
const doubleClickOverride = useActiveDoubleClick(
12+
props.isSelected || false,
13+
onDoubleClick,
14+
);
15+
816
const {
917
canEdit,
1018
isEditing,
@@ -14,8 +22,6 @@ export const EntityItem = (props: EntityItemProps) => {
1422
validateName,
1523
} = props.nameEditorConfig;
1624

17-
const { startIcon, ...rest } = props;
18-
1925
const inEditMode = canEdit ? isEditing : false;
2026

2127
// Use List Item custom title prop to show the editable name
@@ -61,6 +67,7 @@ export const EntityItem = (props: EntityItemProps) => {
6167
customTitleComponent={customTitle}
6268
data-testid={`t--entity-item-${props.title}`}
6369
id={"entity-" + props.id}
70+
onDoubleClick={doubleClickOverride}
6471
rightControl={rightControl}
6572
/>
6673
);

0 commit comments

Comments
 (0)