Skip to content

[Bug]: GET request using Custom Actions does not honour request params #40044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
NilanshBansal opened this issue Apr 3, 2025 · 6 comments
Closed
1 task done
Assignees
Labels
Bug Something isn't working Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage potential-duplicate This label marks issues that are potential duplicates of already open issues Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE

Comments

@NilanshBansal
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Please check the screenshot below.

Image

Steps To Reproduce

  1. Go to app.appsmith.com
  2. Create and authorise slack datasource
  3. Create custom action
    4.Use GET request with slack get replies endpoint
    5.Notice the response from slack says missing parameters but the same request works in Postman.

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

cloud v1.65

@NilanshBansal NilanshBansal added Bug Something isn't working Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE labels Apr 3, 2025
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Apr 3, 2025
Copy link

github-actions bot commented Apr 3, 2025

We have found issues that are potential duplicates:

@github-actions github-actions bot removed the Query & JS Pod Issues related to the query & JS Pod label Apr 3, 2025
@NilanshBansal
Copy link
Contributor Author

@sneha122 @AmanAgarwal041 As per my debugging on this issue, I found out that that all the query params, path params, body etc is not being sent from the client in case of custom action. Only the headers, api url and method is getting sent.

Image

Can you please help in checking this.
cc: @vivek-appsmith

@AmanAgarwal041
Copy link
Contributor

@NilanshBansal As discussed, In the execute api call we don't send any values from the frontend. We just call the execute api with the action id , Hence this needs to be handle from backend side. Let me know if there is something to be done from the client side.

@NilanshBansal
Copy link
Contributor Author

Moving to sprint backlog, instead worked on #40208, #40043

@NilanshBansal
Copy link
Contributor Author

Not required as should be already solved by #40133

@NilanshBansal
Copy link
Contributor Author

NilanshBansal commented Apr 11, 2025

While this issue was already solved by #40133 for the newer versions of Appsmith but since the custom action implementation was introduced in v1.64 and the fix will reach the users in v1.68. I have raised this PR https://github.com/appsmithorg/cloud-services/pull/1969 to fix the issue for older versions as well.
Also, this PR also handles the newer versions well.
cc: @vivek-appsmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage potential-duplicate This label marks issues that are potential duplicates of already open issues Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE
Projects
None yet
Development

No branches or pull requests

4 participants