Skip to content

Commit bf79d7b

Browse files
committed
mkarchiso: prevent interference from xorriso startup files
Options set in xorriso startup files (~/.xorrisorc) could interfere with the xorriso command run by mkarchiso. For example, if ~root/.xorrisorc contains -dummy on, then the ISO file will be empty. Pass -no_rc as the first option to xorriso to prevent interference and unintended behavior. Fixes #153.
1 parent 1d1f9a0 commit bf79d7b

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.rst

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Fixed
1818
-----
1919

2020
- Sign the root file system image only once.
21+
- Make sure xorriso does not read its configuration files to prevent interference and unintended behavior.
2122

2223
Removed
2324
-------

archiso/mkarchiso

+6-1
Original file line numberDiff line numberDiff line change
@@ -1501,11 +1501,16 @@ _build_iso_image() {
15011501

15021502
[[ -d "${out_dir}" ]] || install -d -- "${out_dir}"
15031503

1504+
# Do not read xorriso startup files to prevent interference and unintended behavior.
1505+
# For it to work, -no_rc must be the first argument passed to xorriso.
1506+
xorriso_options=('-no_rc')
1507+
1508+
15041509
if [[ "${quiet}" == "y" ]]; then
15051510
# The when xorriso is run in mkisofs compatibility mode (xorrisofs), the mkisofs option -quiet is interpreted
15061511
# too late (e.g. messages about SOURCE_DATE_EPOCH still get shown).
15071512
# Instead use native xorriso option to silence the output.
1508-
xorriso_options=('-report_about' 'SORRY' "${xorriso_options[@]}")
1513+
xorriso_options+=('-report_about' 'SORRY')
15091514
fi
15101515

15111516
# Add required xorrisofs options for each boot mode

0 commit comments

Comments
 (0)