Skip to content

Commit 7560951

Browse files
Added more accurate terminology
roll, pitch, yaw
1 parent db4c28b commit 7560951

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

examples/Modulino_Movement/Movement_Basic/Movement_Basic.ino

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
ModulinoMovement movement;
1313

1414
float x, y, z;
15-
float gx, gy, gz;
15+
float roll, pitch, yaw;
1616

1717
void setup() {
1818
Serial.begin(9600);
@@ -31,9 +31,9 @@ void loop() {
3131
x = movement.getX();
3232
y = movement.getY();
3333
z = movement.getZ();
34-
gx = movement.getGyroX();
35-
gy = movement.getGyroY();
36-
gz = movement.getGyroZ();
34+
roll = movement.getRoll();
35+
pitch = movement.getPitch();
36+
yaw = movement.getYaw();
3737

3838
// Print acceleration values
3939
Serial.print("A: ");
@@ -47,11 +47,11 @@ void loop() {
4747
Serial.print(" | G: ");
4848

4949
// Print gyroscope values
50-
Serial.print(gx, 1);
50+
Serial.print(roll, 1);
5151
Serial.print(", ");
52-
Serial.print(gy, 1);
52+
Serial.print(pitch, 1);
5353
Serial.print(", ");
54-
Serial.println(gz, 1);
54+
Serial.println(yaw, 1);
5555

5656
delay(200);
5757
}

src/Modulino.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ class ModulinoMovement : public Module {
314314
int update() {
315315
if (initialized) {
316316
int accel = _imu->readAcceleration(x, y, z);
317-
int gyro = _imu->readGyroscope(gx, gy, gz);
317+
int gyro = _imu->readGyroscope(roll, pitch, yaw);
318318
return accel && gyro;
319319
}
320320
return 0;
@@ -334,19 +334,19 @@ class ModulinoMovement : public Module {
334334
float getZ() {
335335
return z;
336336
}
337-
float getGyroX() {
338-
return gx;
337+
float getRoll() {
338+
return roll;
339339
}
340-
float getGyroY() {
341-
return gy;
340+
float getPitch() {
341+
return pitch;
342342
}
343-
float getGyroZ() {
344-
return gz;
343+
float getYaw() {
344+
return yaw;
345345
}
346346
private:
347347
LSM6DSOXClass* _imu = nullptr;
348348
float x,y,z;
349-
float gx,gy,gz;
349+
float roll,pitch,yaw; //gx, gy, gz
350350
int initialized = 0;
351351
};
352352

0 commit comments

Comments
 (0)