Skip to content

Commit 9e634e3

Browse files
committed
feat: add node 20
Remove node 14 as it will be EOL in 5 days. Fixes moltar#1062
1 parent 6544ebb commit 9e634e3

File tree

6 files changed

+16
-6
lines changed

6 files changed

+16
-6
lines changed

.github/workflows/pr.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ jobs:
1414
max-parallel: 3
1515
matrix:
1616
node-version:
17-
- 14.x
1817
- 16.x
1918
- 18.x
2019
- 19.x
20+
- 20.x
2121

2222
steps:
2323
- uses: actions/checkout@v3

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828
# - NODE_VERSIONS in app.tsx
2929
# - NODE_VERSION_FOR_PREVIEW in main.ts
3030
node-version:
31-
- 14.x
3231
- 16.x
3332
- 18.x
3433
- 19.x
34+
- 20.x
3535

3636
steps:
3737
- uses: actions/checkout@v3

README.md

+6
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,9 @@ const res = isMyDataValid(data)
9494
* `npm run start run zod myzod valita` - run benchmarks only for a few selected modules
9595
* `npm run docs:serve` - result viewer
9696
* `npm run test` - run tests on all modules
97+
98+
## Adding a new node version
99+
100+
* update node version matrix in `.github/workflows/pr.yml` and `.github/workflows/release.yml`
101+
* update `NODE_VERSIONS` in `docs/dist/app.tsx` and run `npm run docs:build`
102+
* optionally set `NODE_VERSION_FOR_PREVIEW` in `benchmarks/helpers/main.ts`

benchmarks/helpers/main.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { BenchmarkCase, BenchmarkResult } from './types';
77

88
const DOCS_DIR = join(__dirname, '../../docs');
99
const NODE_VERSION = process.env.NODE_VERSION || process.version;
10-
const NODE_VERSION_FOR_PREVIEW = 19;
10+
const NODE_VERSION_FOR_PREVIEW = 20;
1111

1212
/**
1313
* Run all registered benchmarks and append the results to a file.

docs/app.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as vegaLite from 'vega-lite';
55

66
// which results are attempted to load
77
// the first is selected automatically
8-
const NODE_VERSIONS = [19, 18, 16, 14];
8+
const NODE_VERSIONS = [20, 19, 18, 16];
99

1010
interface BenchmarkResult {
1111
name: string;

docs/dist/app.js

+6-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)