-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support ref installed tool shims #2049
fix: support ref installed tool shims #2049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Morgahl ! I left a couple comments, and the linter is complaining about one line, but I think your PR is pretty close to what we're going to need. I'm going to do some manual testing myself tomorrow and report back on what I see.
I'm thinking shim files should contain the ref:v1.2.3
syntax to match .tool-versions
files, but maybe not.
also update ref version string formatting
@Stratus3D I have made the requested changes by moving the FS format reversion to the |
Summary
I commonly make use of
ref:
based installs when working inerlang
andelixir
repositories, however this appears to be broken in the current builds as theref:
prefix is normalized toref-
when working with file path rendering the ref based installs unlocatable by the shim.Fixes: #2001
Other Information
I do not know if there is a better place to do this, I am happy to make the changes in the correct area if you feel it is needed.