fix: support ref installed tool shims #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morgahl
changed the title
Stratus3D
reviewed
Apr 8, 2025
Stratus3D
reviewed
Apr 8, 2025
Stratus3D
reviewed
Apr 8, 2025
Stratus3D
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Thanks for the PR @Morgahl ! I left a couple comments, and the linter is complaining about one line, but I think your PR is pretty close to what we're going to need. I'm going to do some manual testing myself tomorrow and report back on what I see.
I'm thinking shim files should contain the ref:v1.2.3 syntax to match .tool-versions files, but maybe not.
also update ref version string formatting
|
@Stratus3D I have made the requested changes by moving the FS format reversion to the |
Stratus3D
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I commonly make use of
ref:based installs when working inerlangandelixirrepositories, however this appears to be broken in the current builds as theref:prefix is normalized toref-when working with file path rendering the ref based installs unlocatable by the shim.Fixes: #2001
Other Information
I do not know if there is a better place to do this, I am happy to make the changes in the correct area if you feel it is needed.