Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ref installed tool shims #2049

Merged
merged 6 commits into from
Apr 8, 2025

Conversation

Morgahl
Copy link
Contributor

@Morgahl Morgahl commented Apr 2, 2025

Summary

I commonly make use of ref: based installs when working in erlang and elixir repositories, however this appears to be broken in the current builds as the ref: prefix is normalized to ref- when working with file path rendering the ref based installs unlocatable by the shim.

Fixes: #2001

Other Information

I do not know if there is a better place to do this, I am happy to make the changes in the correct area if you feel it is needed.

@Morgahl Morgahl requested a review from a team as a code owner April 2, 2025 04:07
@Morgahl Morgahl changed the title support ref installed tool shims fix: support ref installed tool shims Apr 2, 2025
Copy link
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Morgahl ! I left a couple comments, and the linter is complaining about one line, but I think your PR is pretty close to what we're going to need. I'm going to do some manual testing myself tomorrow and report back on what I see.

I'm thinking shim files should contain the ref:v1.2.3 syntax to match .tool-versions files, but maybe not.

also update ref version string formatting
@Morgahl
Copy link
Contributor Author

Morgahl commented Apr 8, 2025

@Stratus3D I have made the requested changes by moving the FS format reversion to the installs.Installed directory walk for better consistency. This also surfaced a small change to toolversions.Format's formatting of ref based versions. I added an additional test to cover the new toolversions.VersionStringFromFSFormat function as well.

@Stratus3D Stratus3D merged commit dc24c4a into asdf-vm:master Apr 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "ref:foo" regression in golang rewrite
2 participants