Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asdf 0.16.7 #218343

Closed
wants to merge 1 commit into from
Closed

asdf 0.16.7 #218343

wants to merge 1 commit into from

Conversation

kvokka
Copy link

@kvokka kvokka commented Apr 5, 2025

Adds the checksum for the arm64_linux architecture to ensure the correct binary is installed on those systems. This resolves an issue where the installation would fail due to a missing checksum.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Close asdf-vm/asdf#2054

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Apr 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@kvokka kvokka force-pushed the add-asdf-arm64-linux-bottle branch from 1277793 to 20c44c8 Compare April 5, 2025 07:24
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 5, 2025
@kvokka kvokka force-pushed the add-asdf-arm64-linux-bottle branch from 20c44c8 to 1bbf376 Compare April 5, 2025 07:31
@kvokka
asdf 0.16.7
0bc7587 
Add linux arm64 support
@kvokka kvokka force-pushed the add-asdf-arm64-linux-bottle branch from 1bbf376 to 0bc7587 Compare April 5, 2025 08:12
@kvokka kvokka changed the title build: add arm64_linux sha256 checksum asdf 0.16.7 Apr 5, 2025
@botantony
Copy link
Contributor

Checksums in bottle do represent bottle's checksums (i.e. binaries created by Homebrew during CI) and are added automatically. You should not add them manually

More about bottles: https://docs.brew.sh/Bottles

@botantony
Copy link
Contributor

Full ARM Linux support is not out yet, so it is ok for some formulae not to have binaries for this platform. They still can be built from source

@kvokka
Copy link
Author

kvokka commented Apr 5, 2025

@botantony asdf is a Golang tool with built-in arm64 and Linux support. The official site confirms broad compatibility. The bottle SHA matches the CI, so that should suffice, right?

@botantony
Copy link
Contributor

No, bottle should be created by GitHub workflow and published as a package (https://github.com/orgs/Homebrew/packages). For now just build it with brew install --build-from-source asdf and wait for full ARM Linux support

@fxcoudert
Copy link
Member

This will be added once the go formula in Homebrew has arm64-linux support.

@fxcoudert fxcoudert closed this Apr 5, 2025
@kvokka kvokka deleted the add-asdf-arm64-linux-bottle branch April 5, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Unable to install with brew on arm64 linux machine
3 participants
@kvokka @botantony @fxcoudert