Don't write default config file during init (#720)

* Don't write default config file during init

Per #719, this can cause issues with multiple concurrent processes
executing (for example, parallel MSBuild nodes in a solution).

Retrospectively, it doesn't provide anything useful either.  It's faster
to just create the defaults in memory than to get file IO involved.

Author: jimmylewis

src/LibraryManager/Configuration/Settings.cs

@@ -64,24 +64,18 @@ protected Settings()
                 }
                 catch (JsonReaderException)
                 {
-                    // If there were any errors, we'll reset the file
+                    // If there were any errors, we'll take the defaults
+                    // TODO: log a warning
                 }
             }
 
             if (_rootObject is null)
             {
-                InitSettingsFile(ConfigFilePath);
+                _rootObject = new JObject(new JProperty("config", new JObject()));
+                _configObject = _rootObject["config"] as JObject;
             }
         }
 
-        private void InitSettingsFile(string configFilePath)
-        {
-            _rootObject = new JObject(new JProperty("config", new JObject()));
-            _configObject = _rootObject["config"] as JObject;
-
-            SaveSettingsFile(configFilePath, _rootObject);
-        }
-
         /// <inheritdoc />
         public string UserDataRoot
         {

test/LibraryManager.Test/Configuration/SettingsTest.cs

@@ -47,37 +47,28 @@ public static void Cleanup()
         }
 
         [TestMethod]
-        public void Constructor_FileDoesNotExist_WhenInitialized_CreateNewFile()
+        public void Constructor_FileDoesNotExist()
         {
             if (File.Exists(TestFilePath))
             {
                 File.Delete(TestFilePath);
             }
 
-            _ = new TestSettings(TestFilePath);
+            var settings = new TestSettings(TestFilePath);
 
-            Assert.IsTrue(File.Exists(TestFilePath));
+            // verify settings does not throw, does not have a well-known value
+            Assert.IsFalse(settings.TryGetValue(Constants.HttpsProxy, out _));
         }
 
         [TestMethod]
-        public void Constructor_FileExistsButEmpty_WhenInitialized_PopulateFile()
+        public void Constructor_FileExistsButEmpty()
         {
             File.WriteAllText(TestFilePath, "");
 
-            _ = new TestSettings(TestFilePath);
+            var settings = new TestSettings(TestFilePath);
 
-            Assert.IsTrue(new FileInfo(TestFilePath).Length > 0);
-        }
-
-        [TestMethod]
-        public void Constructor_FileExistsAndIsValid_WhenInitialized_DoNotModify()
-        {
-            string fileText = @"{ ""foo"": {} }";
-            File.WriteAllText(TestFilePath, fileText);
-
-            _ = new TestSettings(TestFilePath);
-
-            Assert.AreEqual(fileText, File.ReadAllText(TestFilePath));
+            // verify settings does not throw, does not have a well-known value
+            Assert.IsFalse(settings.TryGetValue(Constants.HttpsProxy, out _));
         }
 
         [TestMethod]
@@ -86,14 +77,10 @@ public void Constructor_FileExistsButNotJsonObject_Initialize()
             string fileText = @"[]"; // valid JSON, but not an object
             File.WriteAllText(TestFilePath, fileText);
 
-            _ = new TestSettings(TestFilePath);
-
-            string actual = File.ReadAllText(TestFilePath);
-            string expected = @"{
-  ""config"": {}
-}";
+            var settings = new TestSettings(TestFilePath);
 
-            Assert.AreEqual(StringUtility.NormalizeNewLines(expected), StringUtility.NormalizeNewLines(actual));
+            // verify settings does not throw, does not have a well-known value
+            Assert.IsFalse(settings.TryGetValue(Constants.HttpsProxy, out _));
         }
 
         [TestMethod]
@@ -121,19 +108,7 @@ public void TryGetValue_ValueDoesNotExist_ReturnFalseWithEmptyString()
         }
 
         [TestMethod]
-        public void TryGetValue_ValueExists_ReturnTrueWithValue()
-        {
-            string fileText = @"{ ""config"": { ""testKey"": ""testValue"" } }";
-            File.WriteAllText(TestFilePath, fileText);
-
-            bool success = new TestSettings(TestFilePath).TryGetValue("testKey", out string value);
-
-            Assert.IsTrue(success);
-            Assert.AreEqual("testValue", value);
-        }
-
-        [TestMethod]
-        public void TryGetValue_ValueExistsInDifferentCase_ReturnFalse()
+        public void TryGetValue_SettingsNameIsCaseSensitive()
         {
             string fileText = @"{ ""config"": { ""testKey"": ""testValue"" } }";
             File.WriteAllText(TestFilePath, fileText);
@@ -212,7 +187,7 @@ public void SetValue_ValueExists_UpdateValue()
         }
 
         [TestMethod]
-        public void SetEncyptedValue_ValueIsDifferentFromOriginal()
+        public void SetEncryptedValue_ValueIsDifferentFromOriginal()
         {
             var ut = new TestSettings(TestFilePath);