Merge pull request #780 from jimmylewis/normalize

Change file normalization to not lowercase all file names

Author: phil-allen-msft

src/LibraryManager.Contracts/FileHelpers.cs

@@ -385,7 +385,7 @@ public static bool IsUnderRootDirectory(string filePath, string rootDirectory)
         /// Normalizes the path string so it can be easily compared.
         /// </summary>
         /// <remarks>
-        /// Result will be lowercase and have any trailing slashes removed.
+        /// Result will be resolved to an absolute path and have any trailing slashes removed.
         /// </remarks>
         public static string NormalizePath(string path)
         {
@@ -400,17 +400,6 @@ public static string NormalizePath(string path)
                 return path;
             }
 
-            // net451 does not have the OSPlatform apis to determine if the OS is windows or not.
-            // This also does not handle the fact that MacOS can be configured to be either sensitive or insenstive 
-            // to the casing.
-            if (Path.DirectorySeparatorChar == '\\')
-            {
-#pragma warning disable CA1308 // Normalize strings to uppercase
-                               // Reason: we prefer lowercase names for file paths
-                path = path.ToLowerInvariant();
-#pragma warning restore CA1308 // Normalize strings to uppercase
-            }
-
             return Path.GetFullPath(path).TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
         }
 

src/LibraryManager/Providers/BaseProvider.cs

@@ -259,7 +259,7 @@ private OperationResult<LibraryInstallationGoalState> GenerateGoalState(ILibrary
                 mappings.Add(new FileMapping { Destination = desiredState.DestinationPath });
             }
 
-            Dictionary<string, string> installFiles = new();
+            Dictionary<string, string> installFiles = new(StringComparer.OrdinalIgnoreCase);
 
             foreach (FileMapping fileMapping in mappings)
             {