Move localization process to OneLocBuild (#616)

* Add new build step for OneLocBuild process

Because this build step modifies the resource files in-situ, it breaks
build reproducibility.  Moving it to the end should still produce the
outputs necessary to create a PR for localization handbacks.

This required renaming one resx file so that the new tool would generate the correct localized file names.

* Remove MAT-related XLF files

These will be replaced with LCL files from OneLocBuild soon.

We still have XLF files for the VSCT file, which uses a different tool
for conversion.

Author: jimmylewis

Localize/LocProject.json

@@ -0,0 +1,46 @@
+{
+  "Projects": [
+    {
+      "LanguageSet": "VS_Main_Languages",
+      "LocItems": [
+        {
+          "SourceFile": "src\\libman\\Resources\\Text.resx",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\libman\\Resources",
+          "LclFile": "src\\libman\\Resources\\loc\\{Lang}\\Resources\\Text.resx.lcl"
+        },
+        {
+          "SourceFile": "src\\LibraryManager\\Resources\\Text.resx",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\LibraryManager\\Resources",
+          "LclFile": "src\\LibraryManager\\Resources\\loc\\{Lang}\\Resources\\Text.resx.lcl"
+        },
+        {
+          "SourceFile": "src\\LibraryManager.Contracts\\Resources\\Text.resx",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\LibraryManager.Contracts\\Resources",
+          "LclFile": "src\\LibraryManager.Contracts\\Resources\\loc\\{Lang}\\Resources\\Text.resx.lcl"
+        },
+        {
+          "SourceFile": "src\\LibraryManager.Vsix\\Resources\\Text.resx",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\Librarymanager.Vsix\\Resources",
+          "LclFile": "src\\LibraryManager.Vsix\\Resources\\loc\\{Lang}\\Resources\\Text.resx.lcl"
+        },
+        {
+          "SourceFile": "src\\LibraryManager.Vsix\\source.extension.resx",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\LibraryManager.Vsix",
+          "LclFile": "src\\LibraryManager.Vsix\\Resources\\loc\\{Lang}\\source.extension.resx.lcl"
+        },
+        {
+          "$comment": "This is copied from the ENU XLF file by a preceding PowerShell step",
+          "SourceFile": "src\\LibraryManager.Vsix\\Commands\\CommandTable\\LocalizationFiles\\VSCommandTable.xlf",
+          "CopyOption": "LangIdOnName",
+          "OutputPath": "src\\LibraryManager.Vsix\\Commands\\CommandTable\\LocalizationFiles",
+          "LclFile": "src\\LibraryManager.Vsix\\Resources\\loc\\{Lang}\\Commands\\CommandTable\\LocalizationFiles\\VSCommandTable.xlf.lcl"
+        }
+      ]
+    }
+  ]
+}

azure-pipelines/build.yml

@@ -40,6 +40,28 @@ steps:
 - ${{ if eq(variables['system.collectionId'], '011b8bdf-6d56-4f87-be0d-0092136884d9') }}:
   - template: azure-pipeline.microbuild.after.yml
 
+- ${{ if eq(variables['system.collectionId'], '011b8bdf-6d56-4f87-be0d-0092136884d9') }}:
+  - powershell: |
+      New-Item -ItemType Directory ${env:Build_ArtifactStagingDirectory}\locAssets
+  - powershell: |
+      Copy-Item src\LibraryManager.Vsix\Commands\CommandTable\LocalizationFiles\VSCommandTable.en.xlf src\LibraryManager.Vsix\Commands\CommandTable\LocalizationFiles\VSCommandTable.xlf
+  - task: OneLocBuild@2
+    env:
+      SYSTEM_ACCESSTOKEN: $(System.AccessToken)
+    inputs:
+      locProj: 'Localize/LocProject.json'
+      outDir: '$(Build.ArtifactStagingDirectory)\locAssets'
+      repoType: github
+      gitHubPatVariable: '$(OneLocGitHubPat)'
+      prSourceBranchPrefix: 'locfiles'
+    condition: ne(variables['Build.Reason'], 'PullRequest')
+  - task: PublishBuildArtifacts@1
+    inputs:
+      PathtoPublish: '$(Build.ArtifactStagingDirectory)\locAssets'
+      ArtifactName: locAssets
+      ArtifactType: Container
+    displayName: Publish artifacts
+
 - task: CopyFiles@1
   inputs:
     contents: |

azure-pipelines/official.yml

@@ -8,7 +8,6 @@ variables:
   DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
   BuildConfiguration: Release
   BuildPlatform: Any CPU
-  DisableMAT: true
 
 jobs:
   - job: Windows

src/Directory.Build.targets

@@ -16,10 +16,6 @@
   <ItemGroup Condition="'$(TargetFramework)'=='net472'">
     <Reference Include="System.Runtime" />
   </ItemGroup>
-  <!-- Needed for Multilingual App Toolkit-->
-  <ItemGroup>
-    <XliffResource Include="MultilingualResources\*.xlf" />
-  </ItemGroup>
   <ItemGroup>
     <Compile Update="Resources\Text.Designer.cs">
       <DesignTime>True</DesignTime>

src/LibraryManager.Contracts/Microsoft.Web.LibraryManager.Contracts.csproj

@@ -152,7 +152,7 @@
     <None Include="source.extension.vsixmanifest">
       <SubType>Designer</SubType>
       <Generator>VsixManifestGenerator</Generator>
-      <LastGenOutput>source.extension.en.resx</LastGenOutput>
+      <LastGenOutput>source.extension.resx</LastGenOutput>
     </None>
   </ItemGroup>
   <ItemGroup>
@@ -347,7 +347,7 @@
       <MergeWithCTO>true</MergeWithCTO>
       <LogicalName>VSPackage.zh-Hant.Resources</LogicalName>
     </EmbeddedResource>
-    <EmbeddedResource Include="source.extension.en.resx">
+    <EmbeddedResource Include="source.extension.resx">
       <AutoGen>True</AutoGen>
       <DesignTime>True</DesignTime>
       <DependentUpon>source.extension.vsixmanifest</DependentUpon>
@@ -410,9 +410,6 @@
   <ItemGroup>
     <None Include="Commands\CommandTable\LocalizationFiles\VSCommandTable.*.xlf" />
   </ItemGroup>
-  <ItemGroup>
-    <XliffResource Include="MultilingualResources\*.xlf" />
-  </ItemGroup>
   <ItemGroup>
     <FilesToSign Include="$(OutputPath)\Minimatch.dll;$(OutputPath)\Nerdbank.Streams.dll">
       <Authenticode>3PartySHA2</Authenticode>