-
Notifications
You must be signed in to change notification settings - Fork 1
Does this work on organization-owned repos? #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@tkelman - it should work for organizations. Could you ask the admin to check whether all payloads for that webhook have been successfully deployed, and if not, could they report what the response from the server was? (this should all be visible under the web hooks part of the settings). But you are correct that in order to be able to set up the web hooks and see them, you need to be an admin, not just a committer (but they can put the payload URL for your user and that should work). |
(Not sure if it matters, but it will only work for new builds, it will not retroactively change statuses) |
Nevermind, we still had it set to "Just push" instead of Status. All good now: SciML/Sundials.jl#31 I've noticed AppVeyor is able to add the webhooks automatically even if you're just a committer, is that part of GitHub's API documented somewhere? Would be a cool feature to add. Or we can say "Hey GitHub here's what you should be doing" and make this app redundant, that would work too. |
@tkelman - yes, it would be great to have the hook be added automatically, and the API supports it. It's just that I've been short on time :) |
We noticed over at opensim-org/opensim-core#285 that one must be an owner in the organization that contains the repo. Could this be reflected in the documentation at http://github-multi-status.herokuapp.com/, which currently (I believe incorrectly) says:
? |
@chrisdembia - I will update this (but first I will investigate whether it can be made to work by non-owners). Thanks for reporting this! |
Yes it would be great if you could double check. Thank you! This app is terrific. We are very grateful! |
It looks like github may have just rolled out an official version of this: JuliaLang/julia#5045 (comment) |
https://github.com/blog/1935-see-results-from-all-pull-request-status-checks woohoo! Thank you! |
Fantastic! I was hoping that my solution would be only temporary 😄 |
Thanks for filling in a sorely-needed gap in the meantime @astrofrog |
Yes, thank you @astrofrog . |
I'm going to go ahead and close this issue since this is no longer needed :) |
Feodor Fitsner posted a link to this app, thanks so much for making this, I've been wanting exactly this for a few months now.
Unfortunately I tried setting it up on an organization-owned repo (where I have commit access but not admin access, had to bug an admin to turn the webhook on) but it doesn't look like it went through correctly? I opened a test PR at SciML/Sundials.jl#30 and that status is still only showing AppVeyor which finished later than Travis.
Do I maybe need to bug a repo admin again to generate a new payload URL?
The text was updated successfully, but these errors were encountered: