-
-
Notifications
You must be signed in to change notification settings - Fork 136
docs: #1762 Added the community info and links to documentation guides and removed the sponsor part. #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@thulieblack I made the changes as suggested by you in #1762 , Could you please let me know if any improvement is needed . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sonalilipsa17375, great start.
Regarding the community repo and documentation, yes, I did point it out to the Community onboarding docs.
But I would like to see documents like Governance. MD, Charter. MD, and Community Goals file, which highlight the community organization and how we do things.
I hope this will provide some clarity
README.md
Outdated
|
||
- Read the [AsyncAPI Code of Conduct](https://github.com/asyncapi/.github/blob/master/CODE_OF_CONDUCT.md). | ||
- Go through the [AsyncAPI Slack etiquette](https://github.com/asyncapi/community/blob/master/slack-etiquette.md). | ||
- Join our [AsyncAPI Docs Community](https://www.asyncapi.com/docs/community). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a docs community but docs is part of the community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions, I have incorporated this change.
README.md
Outdated
- Go through the [AsyncAPI Slack etiquette](https://github.com/asyncapi/community/blob/master/slack-etiquette.md). | ||
- Join our [AsyncAPI Docs Community](https://www.asyncapi.com/docs/community). | ||
- Add the AsyncAPI calendar from the [AsyncAPI events](https://www.asyncapi.com/community/events) page to stay updated on meetings and events. | ||
- Review the list of [technical writer contributor](https://www.asyncapi.com/docs/community/onboarding-guide/technical-writer-contributor-responsibilities) responsibilities to understand your role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one link to TW onboarding is needed here. Community repo is not only for docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes updated it.
README.md
Outdated
- Tutorials (take time to go through each tutorial) | ||
- Reference | ||
- Set up your local environment following the [AsyncAPI git workflow](https://github.com/asyncapi/community/blob/master/git-workflow.md). | ||
- Introduce yourself in AsyncAPI Slack in the **#01_introductions channel** and the #13_docs channel. Ask docs-related questions in #13_docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
README.md
Outdated
- Reference | ||
- Set up your local environment following the [AsyncAPI git workflow](https://github.com/asyncapi/community/blob/master/git-workflow.md). | ||
- Introduce yourself in AsyncAPI Slack in the **#01_introductions channel** and the #13_docs channel. Ask docs-related questions in #13_docs. | ||
- Request a good first docs issue in the **#13_docs** [Slack channel](https://asyncapi.slack.com/ssb/redirect). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, this is a community repo so it should reflect important community docs not for tech writers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified it, pls share your suggestions. @thulieblack
5214fbb
to
888dbcc
Compare
@thulieblack Can you pls rereview it, I have incorporated the changes you have suggested and also made many design changes. |
Hey @thulieblack, |
cc @TRohit20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only skeptic would be to double check on the click backs and hyperlinks to ensure they work as expected. The rest looks good to me, please ping me after assuring for final review. Thank you
|
||
- ### Getting Started | ||
- **Spec Contribution:** [AsyncAPI Spec Guide](https://github.com/asyncapi/spec/blob/master/CONTRIBUTING.md) | ||
- **Tools Contribution:** [AsyncAPI Tools Guide](https://github.com/asyncapi/.github/blob/master/CONTRIBUTING.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we wanna include only Spec and Tools contribution here? @thulieblack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this section we should remove
Links are working fine, as reviewed from my side. @TRohit20 If anything's required kindly suggest , I can implement those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, @Sonalilipsa17375. Some sections need to be removed, and others can be combined into one. The goal is to make the ReadMe simple but detailed.
--- | ||
|
||
## Community Goals 🎯 | ||
Join us in 2025 as we boost maintainers, streamline onboarding, and create a structured Community Working Group Umbrella. Let's grow together through exciting initiatives like the AsyncAPI Grant Program, conferences, and mentorship. <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section changes and relies on the community goals that change each year. Rather, make it dynamic
└───────────────────────────────┘ | ||
``` | ||
--- | ||
## Community Documentation 📚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should instead be part of the contributing section
3. **Pick an Issue**: Choose an issue to work on and leave a comment introducing yourself. Feel free to ask questions if you're unsure how to get started. | ||
4. **Open a PR**: If no work has been done on the chosen issue, open a PR and start contributing! | ||
|
||
### Technical Writer Onboarding ✍️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put everything related to onboarding under one section
--- | ||
## Our Charter 📜 | ||
|
||
The **[Async API Charter](./CHARTER.md)** outlines the structure, responsibilities, and procedures for contributions and oversight of the AsyncAPI open project. <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The **[Async API Charter](./CHARTER.md)** outlines the structure, responsibilities, and procedures for contributions and oversight of the AsyncAPI open project. <br> | |
The **[AsyncAPI Charter](./CHARTER.md)** outlines the structure, responsibilities, and procedures for contributions and oversight of the AsyncAPI open project. <br> |
|
||
--- | ||
|
||
## Community Governance 🏛️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this section we are having a governance board soon
|
||
--- | ||
|
||
## Async API Technical Steering Committee (TSC) 👥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the TSC and Ambassador sections into one. Maybe rename to "Becoming a TSC or an AsyncAPI Ambassador"
|
||
AsyncAPI Community uses **Slack as the source of communication**. It helps us stay closer to each other and to know each other better through discussions. | ||
|
||
For more details, refer to our **[Slack Etiquette](./slack-etiquette.md)** guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also go under contributing or getting started.
|
||
## Community Discussions 💬 | ||
|
||
AsyncAPI Community uses **Slack as the source of communication**. It helps us stay closer to each other and to know each other better through discussions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, Slack isn't the only form of communication. Maybe it can be something to add in the beginning of the page under welcome.
|
||
### Need Help? 🤝 | ||
|
||
If you have any questions or need guidance, feel free to reach out through our **[Community Discussions](https://asyncapi.com/slack-invite)**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github discussions link shouldn't take you to slack
Description
Before - >>
After - >>
fixes: #1762
Related issue(s) - Link to the issue - #1762