Not reading .gitignore files properly

[mtthlm]

It seems that for me, when files are added to ignored directories, Tree View still thinks that the parent directory of those files added (but ignored) have added files in them. This makes it confusing when I actually add files that belong in VCS. Notice below: If you're at all familiar with Laravel, the directories highlighted in green are ignored... therefore, they should not be considered when new files are added inside of them. Make sense?

[josler]

I get this issue in reverse too. Ignored folders I remove from my .gitignore.

In the console if I do:

repo = atom.project.getRepo()
repo.isPathIgnored('my/path')

It returns true.

Issue with atom core?

[kevinsawicki]

@josler So you are saying atom.project.getRepo().isPathIgnored() is returning the wrong value?

[jyboudreau]

To me it seems like .gitignore files that are in subfolders are not being taken into consideration. Only ignores for the root .gitignore work for me.

[kevinsawicki]

@jyboudreau There were definitely bugs underlying this in libgit2 that have been fixed but not yet released, libgit2/libgit2#2279

The tree-view just uses these APIs directly so I'm optimistic that upgrading libgit2 when it is next released should fix these problems.

[jyboudreau]

@kevinsawicki Awesome, also it seems like the tree view is checking that the project is open in the root as a prerequisite to return true as per directory.coffee:60:

if atom.config.get('tree-view.hideVcsIgnoredFiles')
      repo = atom.project.getRepo()
      return true if repo? and repo.isProjectAtRoot() and repo.isPathIgnored(filePath)

Is this necessary? I often find it useful to have my editor only opened to a subfolder of the git repo depending on the project structure.

[kevinsawicki]

It was added so when people have this setting enabled and they open a subfolder of a repository, it doesn't appear as completely empty if it is an ignored folder itself.

Such as if you ignored node_modules and then do atom node_modules/ from the command line, without this check the tree view in the opened window would be completely empty since node_modules is ignored.

[jyboudreau]

@kevinsawicki Ah, good point. Difficult to solve this nicely for all cases.

[kevinsawicki]

@jyboudreau We could definitely make a setting for it if the current behavior causes issues for other use cases.

[JeanMertz]

I just ran into a similar issue where this didn't work in Atom:

*.pem
!**/files/**/*.pem

it still ignored the accepted *.pem's.

[deiga]

@mtthlm @JeanMertz This seems to work correctly in the current version. Is this still an issue?

[acontreras89]

In case it is, 👍

[fortytw2]

Can confirm that @JeanMertz 's issue is still an issue in 1.7.3 - doesn't seem to display ! paths when they should still be displayed 😢

[austingray]

having this issue right now, here's my .gitignore

# wp core files
*
# keep
!README.md
!wp-content/plugins/.keep
!wp-content/uploads/.keep
!wp-content/themes/themedir/*

only thing highlighting correctly in the tree view is README.md. When I edit individual files within wp-content/themes/themedir/, it highlights the line in the editor to show additions/deletions, and git is tracking files correctly when I use git status. Only thing not working is highlighting in the tree view. Thank you!