Fix incorrect peer port autodetection and substream limit exceeded errors #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhavyas
reviewed
Mar 24, 2025
There was a problem hiding this comment.
Looks like of the 3 PR from upstream, one of the them is already in [stable2412-2](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2412-2)
Can we not ask upstream to backport the remaining two into the another stable2412 release ?
We can then pull the release instead
They will not backport it because upstream |
teor2345
force-pushed
the
conn-stream-fixes
branch
from
13c7c4d to
ce58e8c
Compare
vedhavyas
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our substrate fork to include 3 network connection/stream bug fixes:
A peer address autodetection fix, which works around a libp2p bug that pollutes the peer set with ephemeral outbound ports:
Identifyobserved addresses to discover external addresses paritytech/polkadot-sdk#7338Peer connection substream fixes, which correctly detect and react to I/O errors on connections by closing substreams:
std::io::Errorsparitytech/polkadot-sdk#7724Close #3450
Some updates were required to other dependencies to resolve lockfile version conflicts.
Code contributor checklist: