use retdec-decompiler instead of retdec-decompiler.py

Author: PeterMatula

docs/index.rst

@@ -8,7 +8,7 @@ Welcome to Regression Tests' Documentation!
 
 This is a documentation for the `regression tests framework <https://github.com/avast/retdec-regression-tests-framework/>`_. It describes how to write regression tests for `RetDec <https://github.com/avast/retdec/>`_ and its tools, and provides an overview of the supported functions and methods.
 
-The documentation is primarily focused on tests for the RetDec decompiler, i.e. for the ``retdec-decompiler.py`` script. You can, however, write tests for arbitrary RetDec-related tools, such as ``fileinfo`` or ``unpacker``. This is described in section :doc:`tests_for_arbitrary_tools`. Nevertheless, it is highly recommended to read the whole documentation, even if you plan to write tests only for a single tool.
+The documentation is primarily focused on tests for the RetDec decompiler, i.e. for the ``retdec-decompiler`` script. You can, however, write tests for arbitrary RetDec-related tools, such as ``fileinfo`` or ``unpacker``. This is described in section :doc:`tests_for_arbitrary_tools`. Nevertheless, it is highly recommended to read the whole documentation, even if you plan to write tests only for a single tool.
 
 Table of Contents
 =================

docs/test_settings.rst

@@ -27,11 +27,11 @@ The name can by any valid Python identifier, written conventionally in ``snake_c
         arch='x86'
     )
 
-From the above settings, the following ``retdec-decompiler.py`` argument list is automatically created:
+From the above settings, the following ``retdec-decompiler`` argument list is automatically created:
 
 .. code-block:: text
 
-    retdec-decompiler.py file.exe -a x86
+    retdec-decompiler file.exe -a x86
 
 For a complete list of possible arguments to the initializer, see the description of :class:`~tools.decompiler_test_settings.DecompilerTestSettings`.
 
@@ -48,8 +48,8 @@ For such settings, the following two decompilations are run:
 
 .. code-block:: text
 
-    retdec-decompiler.py file.exe -a x86
-    retdec-decompiler.py file.exe -a arm
+    retdec-decompiler file.exe -a x86
+    retdec-decompiler file.exe -a arm
 
 That is, the regression tests framework runs a single decompilation for every combination of the values specified in the settings.
 
@@ -122,7 +122,7 @@ We want to decompile ``file1.exe`` on ``x86`` and ``arm``, and ``file2.elf`` on
 Arbitrary Parameters for the Decompiler
 ---------------------------------------
 
-If you look at the complete list of possible arguments (:class:`~tools.decompiler_test_settings.DecompilerTestSettings`), you see that not all ``retdec-decompiler.py`` parameters may be specified as arguments to :class:`TestSettings`. The reason is that ``retdec-decompiler.py`` provides too many parameters and their support in the form of arguments would be cumbersome. However, it is possible to specify arbitrary arguments that are directly passed to the ``retdec-decompiler.py`` script via the ``args`` argument:
+If you look at the complete list of possible arguments (:class:`~tools.decompiler_test_settings.DecompilerTestSettings`), you see that not all ``retdec-decompiler`` parameters may be specified as arguments to :class:`TestSettings`. The reason is that ``retdec-decompiler`` provides too many parameters and their support in the form of arguments would be cumbersome. However, it is possible to specify arbitrary arguments that are directly passed to the ``retdec-decompiler`` via the ``args`` argument:
 
 .. code-block:: python
 
@@ -137,17 +137,17 @@ These settings result into the creation of the following decompilation:
 
 .. code-block:: text
 
-    retdec-decompiler.py file.exe -a x86 --select-decode-only --select-functions func1,func2
+    retdec-decompiler file.exe -a x86 --select-decode-only --select-functions func1,func2
 
-In a greater detail, the ``args`` argument is taken, split into sub-arguments by whitespace, and passed to the ``retdec-decompiler.py`` script. The argument list internally looks like this:
+In a greater detail, the ``args`` argument is taken, split into sub-arguments by whitespace, and passed to the ``retdec-decompiler``. The argument list internally looks like this:
 
 .. code-block:: python
 
     ['file.exe', '-a', 'x86', '--select-decode-only', '--select-functions', 'func1,func2']
 
 .. hint::
 
-    When it is possible to specify a ``retdec-decompiler.py`` parameter in the form of a named argument (like architecture or endianness), always prefer it to specifying raw arguments by using the ``args`` argument. That is, do **not** write
+    When it is possible to specify a ``retdec-decompiler`` parameter in the form of a named argument (like architecture or endianness), always prefer it to specifying raw arguments by using the ``args`` argument. That is, do **not** write
 
     .. code-block:: python
 
@@ -157,7 +157,7 @@ In a greater detail, the ``args`` argument is taken, split into sub-arguments by
                 args='-a x86'   # Always prefer using arch='x86'.
             )
 
-    The reason is that named arguments are less prone to changes in ``retdec-decompiler.py``. Indeed, when such an argument changes in ``retdec-decompiler.py``, all that has to be done is changing the internal mapping of named arguments to ``retdec-decompiler.py`` arguments. No test needs to be changed.
+    The reason is that named arguments are less prone to changes in ``retdec-decompiler``. Indeed, when such an argument changes in ``retdec-decompiler``, all that has to be done is changing the internal mapping of named arguments to ``retdec-decompiler`` arguments. No test needs to be changed.
 
 If you want to specify separate arguments for several decompilations for single settings, place them into a list when specifying the settings. For example, consider the following test class:
 
@@ -177,8 +177,8 @@ It results into these two decompilations:
 
 .. code-block:: text
 
-    retdec-decompiler.py file.elf -a x86 --select-decode-only --select-functions func1,func2
-    retdec-decompiler.py file.elf -a x86 --select-decode-only --select-functions func3
+    retdec-decompiler file.elf -a x86 --select-decode-only --select-functions func1,func2
+    retdec-decompiler file.elf -a x86 --select-decode-only --select-functions func3
 
 You can also specify multiple settings, as already described earlier in this section.
 

regression_tests/tools/decompiler.py

@@ -138,7 +138,7 @@ def fileinfo_outputs(self):
                 (?:
                     \#\#\#\#\#\                          # Ended correctly.
                 |
-                    \./retdec-decompiler.py:\ line\ \d+: # Failed (segfault etc.).
+                    \./retdec-decompiler:\ line\ \d+: # Failed (segfault etc.).
                 )
             """, self.log, re.VERBOSE | re.MULTILINE | re.DOTALL)
         return [FileinfoOutput(output.strip()) for output in outputs]

regression_tests/tools/decompiler_runner.py

@@ -17,7 +17,7 @@ def _tool_class(self):
 
     @overrides(ToolRunner)
     def _get_tool_executable_name(self, tool_name):
-        return 'retdec-decompiler.py'
+        return 'retdec-decompiler'
 
     @overrides(ToolRunner)
     def _initialize_tool_dir_and_args(self, dir, args):

runner.py

@@ -76,7 +76,7 @@ def ensure_all_required_settings_are_set(config):
         print_error("'retdec_install_dir' in the [runner] section of config_local.ini "
                     "points to a non-existing directory")
         sys.exit(1)
-    elif not os.path.exists(os.path.join(retdec_install_dir, 'bin', 'retdec-decompiler.py')):
+    elif not os.path.exists(os.path.join(retdec_install_dir, 'bin', 'retdec-decompiler')):
         print_error("'retdec_install_dir' in the [runner] section of config_local.ini "
                     "does not seem to point to RetDec")
         sys.exit(1)
@@ -143,7 +143,7 @@ def adjust_environment(config, args):
     if config['runner'].getboolean('idaplugin_tests_enabled'):
         tools_dir = os.path.join(config['runner']['retdec_install_dir'], 'bin')
 
-        # run-ida-decompilation.py requires retdec-decompiler.py to be reachable from PATH.
+        # run-ida-decompilation.py requires retdec-decompiler to be reachable from PATH.
         os.environ['PATH'] = tools_dir + os.pathsep + os.environ['PATH']
 
         # run-ida-decompilation.py requires path to IDA Pro.
@@ -166,7 +166,7 @@ def adjust_environment(config, args):
     if config['runner'].getboolean('r2plugin_tests_enabled'):
         tools_dir = os.path.join(config['runner']['retdec_install_dir'], 'bin')
 
-        # run-r2-decompilation.py requires retdec-decompiler.py to be reachable from PATH.
+        # run-r2-decompilation.py requires retdec-decompiler to be reachable from PATH.
         os.environ['PATH'] = tools_dir + os.pathsep + os.environ['PATH']
 
         # Copy run-r2-decompilation.py into the directory where other tools

tests/tools/decompiler_runner_tests.py

@@ -32,7 +32,7 @@ def test_tool_class_returns_decompilation(self):
     def test_get_tool_executable_name_returns_correct_name(self):
         self.assertEqual(
             self.decomp_runner._get_tool_executable_name('decompiler'),
-            'retdec-decompiler.py'
+            'retdec-decompiler'
         )
 
     def test_initialize_tool_dir_and_args_just_returns_args_when_config_file_is_not_set(self):