Skip to content

Make updateState available in constructor instead of componentDidMount #56

Open
@GerritSe

Description

@GerritSe

Hey there. We recently started using react-copy-write in a small application and had a great experience so far, but there is still something that interferes with our application flow, which is the inability to call mutate before a provider is fully mounted.

https://codesandbox.io/s/oowloz2qk9

In this example the app will crash, because mutate is called before the surrounding provider is fully mounted. We want our ApiProvider to be wrapped around the whole app while still being able to use life cycle hooks to do initialization work that could mutate the state this provider gives us.

What we did for experimental reasons is to move the componentDidMount code from CopyOnWriteStoreProvider to a constructor and everything worked fine afterwards. So my question is whether it's possible to do this switch or if there are special reasons for the design decision to make updateState only available after componentDidMount of CopyOnWriteStoreProvider ran? Are there any performance implications or other pitfalls we are overlooking? If not I'd be glad to open a PR for this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions