Skip to content

Commit 1d79229

Browse files
committed
fix: ignore field setting in sdkUpdate DBInstance
When we make a ModifyDBInstance call, the output returned is outdated. Currently we've been relying on `pendingModifiedValues` to return the desired field values, but based on the longs, pendingModifiedValues is not a reliable source. These changes specifically ignore setting the fields after ModifyDBInstance is called. A better approach can be to ignore setting anything after Update is called. Just in case we're missing some values that we should ignore instead!!!
1 parent fef8753 commit 1d79229

File tree

6 files changed

+131
-240
lines changed

6 files changed

+131
-240
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-05-02T16:42:27Z"
2+
build_date: "2025-05-12T18:04:21Z"
33
build_hash: f8dc5330705b3752ce07dce0ac831161fd4cb14f
4-
go_version: go1.24.2
4+
go_version: go1.24.3
55
version: v0.45.0
66
api_directory_checksum: 52968d74358773de28be65be320d1bfb9c91e0bf
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: ced2b68c703e2daf7b04da8f84f6ad6c95114fb9
10+
file_checksum: a631c487e47b31b1b7eb3242b48efa8950322f3c
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,8 @@ resources:
298298
hooks:
299299
delta_pre_compare:
300300
template_path: hooks/db_instance/delta_pre_compare.go.tpl
301+
# sdk_delete_post_request:
302+
# code: return r, fmt.Errorf("wait for delete")
301303
sdk_create_pre_build_request:
302304
template_path: hooks/db_instance/sdk_create_pre_build_request.go.tpl
303305
sdk_create_post_set_output:
@@ -327,11 +329,61 @@ resources:
327329
is_immutable: true
328330
DBInstanceIdentifier:
329331
is_primary_key: true
332+
set:
333+
- method: Update
334+
ignore: true
330335
DBInstanceStatus:
331336
print:
332337
name: "STATUS"
333338
MasterUserPassword:
334339
is_secret: true
340+
set:
341+
- method: Update
342+
ignore: true
343+
AllocatedStorage:
344+
set:
345+
- method: Update
346+
ignore: true
347+
BackupRetentionPeriod:
348+
set:
349+
- method: Update
350+
ignore: true
351+
CACertificateIdentifier:
352+
set:
353+
- method: Update
354+
ignore: true
355+
DBInstanceClass:
356+
set:
357+
- method: Update
358+
ignore: true
359+
EngineVersion:
360+
set:
361+
- method: Update
362+
ignore: true
363+
Iops:
364+
set:
365+
- method: Update
366+
ignore: true
367+
MultiAZ:
368+
set:
369+
- method: Update
370+
ignore: true
371+
Port:
372+
set:
373+
- method: Update
374+
ignore: true
375+
PubliclyAccessible:
376+
set:
377+
- method: Update
378+
ignore: true
379+
StorageThroughput:
380+
set:
381+
- method: Update
382+
ignore: true
383+
StorageType:
384+
set:
385+
- method: Update
386+
ignore: true
335387
KmsKeyId:
336388
references:
337389
resource: Key

generator.yaml

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,8 @@ resources:
298298
hooks:
299299
delta_pre_compare:
300300
template_path: hooks/db_instance/delta_pre_compare.go.tpl
301+
# sdk_delete_post_request:
302+
# code: return r, fmt.Errorf("wait for delete")
301303
sdk_create_pre_build_request:
302304
template_path: hooks/db_instance/sdk_create_pre_build_request.go.tpl
303305
sdk_create_post_set_output:
@@ -327,11 +329,61 @@ resources:
327329
is_immutable: true
328330
DBInstanceIdentifier:
329331
is_primary_key: true
332+
set:
333+
- method: Update
334+
ignore: true
330335
DBInstanceStatus:
331336
print:
332337
name: "STATUS"
333338
MasterUserPassword:
334339
is_secret: true
340+
set:
341+
- method: Update
342+
ignore: true
343+
AllocatedStorage:
344+
set:
345+
- method: Update
346+
ignore: true
347+
BackupRetentionPeriod:
348+
set:
349+
- method: Update
350+
ignore: true
351+
CACertificateIdentifier:
352+
set:
353+
- method: Update
354+
ignore: true
355+
DBInstanceClass:
356+
set:
357+
- method: Update
358+
ignore: true
359+
EngineVersion:
360+
set:
361+
- method: Update
362+
ignore: true
363+
Iops:
364+
set:
365+
- method: Update
366+
ignore: true
367+
MultiAZ:
368+
set:
369+
- method: Update
370+
ignore: true
371+
Port:
372+
set:
373+
- method: Update
374+
ignore: true
375+
PubliclyAccessible:
376+
set:
377+
- method: Update
378+
ignore: true
379+
StorageThroughput:
380+
set:
381+
- method: Update
382+
ignore: true
383+
StorageType:
384+
set:
385+
- method: Update
386+
ignore: true
335387
KmsKeyId:
336388
references:
337389
resource: Key

0 commit comments

Comments
 (0)