Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Commit 04e5078

Browse files
authored
Merge pull request #645 from aws-samples/doc/poc-guidance
poc guidance improvement and minor fix
2 parents 6f8d3dc + ffd8bda commit 04e5078

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

poc/cdk.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"@aws-cdk/aws-iam:standardizedServicePrincipals": true,
3636
"@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker": true,
3737
"@aws-cdk/aws-iam:importedRoleStackSafeDefaultPolicyName": true,
38-
"@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy": true,
38+
"@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy": false,
3939
"@aws-cdk/aws-route53-patters:useCertificate": true,
4040
"@aws-cdk/customresources:installLatestAwsSdkDefault": false,
4141
"@aws-cdk/aws-rds:databaseProxyUniqueResourceName": true,

poc/poc/poc_stack.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
KubernetesVersion,
1010
Cluster
1111
)
12-
from aws_cdk.aws_prometheus import(
13-
PrometheusWorkspace
12+
from aws_cdk.aws_aps import(
13+
CfnWorkspace
1414
)
1515
import aws_cdk.aws_iam as iam
1616

@@ -21,7 +21,7 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
2121

2222
kubectl = KubectlV22Layer (self, 'kubectl_layer')
2323

24-
prometheus_workspace = PrometheusWorkspace(self, 'PrometheusWorkspace')
24+
prometheus_workspace = CfnWorkspace(self, 'PrometheusWorkspace')
2525

2626
emr_eks = ara.EmrEksCluster.get_or_create(self,
2727
eks_cluster_name='poc-cluster',
@@ -66,4 +66,4 @@ def __init__(self, scope: Construct, construct_id: str, **kwargs) -> None:
6666
CfnOutput(self, 'VirtualClusterId', value=my_vc.attr_id)
6767
CfnOutput(self, 'RoleArn', value=role.role_arn)
6868
CfnOutput(self, 'CriticalConfig', value=emr_eks.critical_default_config)
69-
CfnOutput(self, 'Prometheus', value=prometheus_workspace.attr_id)
69+
CfnOutput(self, 'Prometheus', value=prometheus_workspace.attr_arn)

0 commit comments

Comments
 (0)