Skip to content
This repository was archived by the owner on Jul 16, 2024. It is now read-only.

Commit 3cb80e4

Browse files
authored
fix: change ARA access log bucket default configuration for owner to the writer (#624)
1 parent 1f62861 commit 3cb80e4

File tree

5 files changed

+416
-205
lines changed

5 files changed

+416
-205
lines changed

core/API.md

Lines changed: 159 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/package.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/src/ara-bucket.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ export interface AraBucketProps {
126126

127127
/**
128128
* The objectOwnership of the bucket.
129-
* @default - No ObjectOwnership configuration, uploading account will own the object.
129+
* @default - Writer account will own the object.
130130
*/
131131
readonly objectOwnership?: ObjectOwnership;
132132

@@ -205,7 +205,11 @@ export class AraBucket extends Bucket {
205205

206206
var serverAccessLogsBucket = undefined;
207207
if (props.serverAccessLogsPrefix) {
208-
serverAccessLogsBucket = props.serverAccessLogsBucket || AraBucket.getOrCreate(scope, { bucketName: 's3-access-logs', encryption: BucketEncryption.S3_MANAGED });
208+
serverAccessLogsBucket = props.serverAccessLogsBucket || AraBucket.getOrCreate(scope, {
209+
bucketName: 's3-access-logs',
210+
encryption: BucketEncryption.S3_MANAGED,
211+
objectOwnership: ObjectOwnership.OBJECT_WRITER,
212+
});
209213
}
210214

211215
// If using KMS encryption then use a customer managed key, if not set the key to undefined

core/test/e2e/ara-bucket.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ jest.setTimeout(100000);
1717
const integTestApp = new cdk.App();
1818
const stack = new cdk.Stack(integTestApp, 'AraBucketE2eTest');
1919

20-
const araBucket = AraBucket.getOrCreate(stack, { bucketName: 'my-ara-bucket' });
20+
const araBucket = AraBucket.getOrCreate(stack, {
21+
bucketName: 'my-ara-bucket',
22+
serverAccessLogsPrefix: 'test',
23+
});
2124

2225
new cdk.CfnOutput(stack, 'BucketName', {
2326
value: araBucket.bucketName,

0 commit comments

Comments
 (0)