Skip to content

java_test_suite cannot use Make variable substitution #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thirtyseven opened this issue Mar 25, 2025 · 0 comments · May be fixed by #332
Open

java_test_suite cannot use Make variable substitution #334

thirtyseven opened this issue Mar 25, 2025 · 0 comments · May be fixed by #332

Comments

@thirtyseven
Copy link
Contributor

thirtyseven commented Mar 25, 2025 •
edited
Loading

Version: 0.28.0

Example:

java_test_suite(
    name = "ExampleSuite",
    srcs = glob(["*.java"]),
    jvm_flags = ["-javaagent:$(location @maven//:org_jmockit_jmockit)"],
    deps = [
        artifact("org.jmockit:jmockit"),
    ],
)

Expected: Builds successfully
Actual:

ERROR: /Users/thirtyseven/oss/rules_jvm/examples/tests_and_lints/src/test/com/github/bazel_contrib/contrib_rules_jvm/examples/tests_and_lints/suite/BUILD.bazel:4:16: in java_test rule //src/test/com/github/bazel_contrib/contrib_rules_jvm/examples/tests_and_lints/suite:ExampleTest: label '@@rules_jvm_external~~maven~maven//:org_jmockit_jmockit' in $(location) expression is not a declared prerequisite of this rule

This is a regression from 0.27.0 caused by #303.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure deps referenced in java_test_suite make vars are passed to tests thirtyseven/rules_jvm
1 participant
@thirtyseven