Mention migration for EntityCommand::apply

[janhohenheim]

Before:

struct Foo;

impl EntityCommand for Foo {
    fn apply(self, entity: Entity, world: &mut World) {
        world
            .run_system_cached_with(print_entity, entity)
            .unwrap();
    }
}

fn print_entity(In(entity): In<Entity>) {
    info!("entity: {entity}");
}

After:

struct Foo;

impl EntityCommand for Foo {
    fn apply(self, entity_world: EntityWorldMut) {
        let entity = entity_world.id();
        entity_world
            .into_world_mut()
            .run_system_cached_with(print_entity, entity)
            .unwrap();
    }
}

fn print_entity(In(entity): In<Entity>) {
    info!("entity: {entity}");
}

I failed to find the commit that changed this, so other related methods may also have been changed.
Note that the .id() API call is a bit strange; I would have expected the method to be called .entity().

[alice-i-cecile]

Note that the .id() API call is a bit strange; I would have expected the method to be called .entity()

This is consistent with the EntityCommands API :)

[janhohenheim]

@alice-i-cecile fair enough! Then I consider that API strange as well :P No big deal though :)

[alice-i-cecile]

This was changed after bevyengine/bevy#17043, so quite late in the cycle.

Going through the commits for https://github.com/bevyengine/bevy/commits/06f9e5eca5413160b24c0fc3a4efa174952be14b/crates/bevy_ecs/src/system/commands/entity_command.rs

[alice-i-cecile]

Done in bevyengine/bevy#17215