Too many open files

Philipp Heckel · Philipp Heckel · commit 6a71746922b4 · 2020-05-10T16:24:47.000-04:00
diff --git a/manifest.go b/manifest.go
@@ -290,7 +290,6 @@ func (m *manifest) MergeAtOffset(offset int64, other *manifest) {
 }
 
 func (m *manifest) WriteToFile(file string) error {
-	// Save to file
 	buffer, err := proto.Marshal(m.Proto())
 	if err != nil {
 		return err
diff --git a/store_file.go b/store_file.go
@@ -71,6 +71,7 @@ func (idx *fileChunkStore) ReadAt(checksum []byte, buffer []byte, offset int64)
 	if err != nil {
 		return 0, err
 	}
+	defer chunk.Close()
 
 	read, err := chunk.ReadAt(buffer, offset)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,6 @@ func (m manifest) MergeAtOffset(offset int64, other manifest) {`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`func (m *manifest) WriteToFile(file string) error {`
`293`		`- // Save to file`
`294`	`293`	`buffer, err := proto.Marshal(m.Proto())`
`295`	`294`	`if err != nil {`
`296`	`295`	`return err`
Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,7 @@ func (idx *fileChunkStore) ReadAt(checksum []byte, buffer []byte, offset int64)`
`71`	`71`	`if err != nil {`
`72`	`72`	`return 0, err`
`73`	`73`	`}`
	`74`	`+ defer chunk.Close()`
`74`	`75`
`75`	`76`	`read, err := chunk.ReadAt(buffer, offset)`
`76`	`77`	`if err != nil {`