Skip to content

Commit 2a1df82

Browse files
committed
feat(eslint 8):
BREAKING CHANGE: requires eslint-plugin-prettier, several new rules
1 parent 95a6de2 commit 2a1df82

File tree

4 files changed

+720
-863
lines changed

4 files changed

+720
-863
lines changed

index.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ module.exports = {
77
'plugin:functional/external-recommended',
88
'plugin:functional/all',
99
'prettier',
10-
'prettier/@typescript-eslint',
1110
],
1211
rules: {
1312
'max-lines': ['error', 1000],
@@ -64,9 +63,11 @@ module.exports = {
6463
'import/newline-after-import': 'error',
6564
'import/no-absolute-path': 'error',
6665
'import/no-amd': 'error',
66+
'import/no-cycle': 'error',
6767
'import/no-default-export': 'error',
6868
'import/no-mutable-exports': 'error',
6969
'import/no-named-default': 'error',
70+
'import/no-commonjs': 'error',
7071
'import/no-named-export': 'off',
7172
'import/no-self-import': 'error',
7273
'import/no-useless-path-segments': 'error',
@@ -97,6 +98,10 @@ module.exports = {
9798
],
9899
'@typescript-eslint/explicit-function-return-type': 'off',
99100
'@typescript-eslint/explicit-module-boundary-types': 'off',
101+
'@typescript-eslint/prefer-literal-enum-member': [
102+
'error',
103+
{ allowBitwiseExpressions: true },
104+
],
100105
'functional/prefer-readonly-type': 'off', // disabled in favor of @typescript-eslint/prefer-readonly-parameter-types
101106
'functional/prefer-type-literal': 'off',
102107
'one-var': 'off',
@@ -106,5 +111,9 @@ module.exports = {
106111
'no-warning-comments': 'off',
107112
'no-loss-of-precision': 'off',
108113
'@typescript-eslint/no-loss-of-precision': ['error'],
114+
'@typescript-eslint/consistent-indexed-object-style': [
115+
'error',
116+
'index-signature',
117+
],
109118
},
110119
};

package.json

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@
55
"main": "index.js",
66
"license": "MIT",
77
"peerDependencies": {
8-
"@typescript-eslint/parser": ">=3",
9-
"eslint": ">=7",
10-
"eslint-plugin-eslint-comments": ">=3.1",
11-
"eslint-plugin-functional": ">=3",
12-
"eslint-plugin-import": ">=2.21",
13-
"eslint-plugin-tsdoc": ">=0.2.5",
14-
"typescript": ">=3.9"
8+
"@typescript-eslint/parser": ">=5.9",
9+
"eslint": ">=8",
10+
"eslint-plugin-eslint-comments": ">=3.2",
11+
"eslint-plugin-functional": ">=4",
12+
"eslint-plugin-import": ">=2.25",
13+
"typescript": ">=4.5"
1514
},
1615
"dependencies": {
17-
"@typescript-eslint/eslint-plugin": "3.3.0",
18-
"eslint-config-prettier": "^6.11.0"
16+
"@typescript-eslint/eslint-plugin": "5.9.1",
17+
"eslint-config-prettier": "^8.3.0"
1918
},
2019
"scripts": {
2120
"release": "standard-version"
@@ -25,7 +24,7 @@
2524
"eslintconfig"
2625
],
2726
"devDependencies": {
28-
"standard-version": "^8.0.0"
27+
"standard-version": "^9.3.2"
2928
},
3029
"config": {
3130
"commitizen": {

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ A very strict eslint configuration, including rules which require:
1414
First, configure your project for [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint). Then install `eslint-config-bitauth` and the required plugins.
1515

1616
```
17-
npm install --dev eslint @typescript-eslint/parser eslint-config-bitauth eslint-plugin-functional eslint-plugin-eslint-comments eslint-plugin-import eslint-plugin-tsdoc
17+
npm install --dev eslint @typescript-eslint/parser eslint-config-bitauth eslint-plugin-functional eslint-plugin-eslint-comments eslint-plugin-import eslint-plugin-tsdoc eslint-plugin-prettier
1818
```
1919

2020
Then add `bitauth` to the `extends` array in your ESLint configuration.

0 commit comments

Comments
 (0)