Skip to content

Need to upgrade to bdk 0.17 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
notmandatory opened this issue Mar 30, 2022 · 2 comments
Closed

Need to upgrade to bdk 0.17 #4

notmandatory opened this issue Mar 30, 2022 · 2 comments

Comments

@notmandatory
Copy link
Member

notmandatory commented Mar 30, 2022 •
edited
Loading

I had to temporarily comment out the bdk-reserves tests in bitcoindevkit/bdk-cli#73. Please make a new release of this project with bdk 0.17 and then we can re-enable those tests. The issue is that bdk-reserves and bdk-cli need to be using the same version of bdk.
@notmandatory notmandatory mentioned this issue Mar 30, 2022
Merged
6 tasks
@ulrichard
Copy link
Collaborator

ulrichard commented Mar 31, 2022 •
edited
Loading

Hi @notmandatory , thanks for the heads up. I missed the release of bdk 0.17.
I just released bdk-reserves 0.17
I also started adapting the relevant parts of bdk-cli base on your branch. But I can only do this with low priority, so maybe you are quicker with that.

@notmandatory
Copy link
Member Author

Thanks for the updated bdk-reserves 0.17. I'll take a crack at updating the bdk-cli with it for the next release.

notmandatory referenced this issue in bitcoindevkit/bdk-cli Apr 1, 2022
@notmandatory
Merge #73: Update to bdk 0.17.0
92d06d6 
42f1881 Minor cleanup (Steve Myers)
14cbbd1 Update bdk-reserves to 0.17 and re-enable ci tests (Steve Myers)
7becf6f Fix tests (Steve Myers)
ac8cb34 Update changelog (Steve Myers)
735be18 Update sync and broadcast sub-commands for bdk 0.17 (Steve Myers)
36aec33 Update Cargo.lock (Steve Myers)
174b56a Add verify feature (Steve Myers)
2f843fd Bump version to 0.5.0 (Steve Myers)
8afc115 Update bdk version to 0.17 (Steve Myers)
c1c6503 [WIP] Update to bdk 0.17.0 (Steve Myers)

Pull request description:

  ### Description

  Fixes #81

  ### Notes to the reviewers

  Also added `verify` feature flag which enables transaction verification against consensus rules during sync.

  I also had to disable the `reserves` tests and that feature will be broken until we can get it updated to use `bdk` `0.17` also.  I created an issue https://github.com/weareseba/bdk-reserves/issues/4.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [x] I've updated `CHANGELOG.md`

Top commit has no ACKs.

Tree-SHA512: 081f795122596e21b196955292bd701ce3097fb3e94e18b1775232b2097c614b955cd1452694542d5a42374a470efdbb3d09043ab22c7b28f5203874bed53b67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulrichard @notmandatory