Skip to content

txout_index, Descriptor not needed in keychains_to_descriptors #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
notmandatory opened this issue May 10, 2024 · 1 comment
Closed

txout_index, Descriptor not needed in keychains_to_descriptors #1439

notmandatory opened this issue May 10, 2024 · 1 comment
Labels
module-blockchain
Milestone
1.0.0-alpha

Comments

@notmandatory
Copy link
Member 

          The `Descriptor` does not need to be here. You can just look it up in `descriptor_ids_to_descriptors`.

Originally posted by @LLFourn in #1203 (comment)
@notmandatory notmandatory moved this to Todo in BDK Wallet May 10, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone May 10, 2024
@evanlinjin evanlinjin mentioned this issue Jun 5, 2024
Closed
8 tasks
@notmandatory notmandatory moved this from Todo to Needs Review in BDK Wallet Jun 6, 2024
@notmandatory
Copy link
Member Author

fixed by #1463

@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module-blockchain
Projects
BDK Wallet
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

Various improvements not included in #1203 (new) LagginTimes/bdk
1 participant
@notmandatory