Skip to content

error::MissingCachedScripts and error::MiniscriptPsbtError are not exported #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnull opened this issue May 29, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@tnull
Copy link
Contributor

tnull commented May 29, 2023

Describe the bug
error::MissingCachedScripts and error::MiniscriptPsbtError are not exported to the user even though exposed through Error variants. While exposing them is easy enough, I wasn't quite sure what the correct docs are for all of the MiniscriptPsbtError variants.

Expected behavior
Both error types should be exposed and well documented, as otherwise it's hard to know how to handle them properly.

Build environment
BDK 0.28.0

Additional context
Might be a pre-requisite if we were to explore implementing a quick-and-dirty async fork of RpcBlockchain (see #998 for more context).

@tnull tnull added the bug Something isn't working label May 29, 2023
@tnull tnull changed the title error::MissingCachedScripts and error::MiniscriptPsbtError are not exposed error::MissingCachedScripts and error::MiniscriptPsbtError are not exported May 29, 2023
@notmandatory notmandatory moved this to Discussion in BDK Chain Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Discussion
Development

No branches or pull requests

1 participant