Skip to content

Migrate to cmake #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 of 18 tasks
luke-jr opened this issue Dec 5, 2024 · 8 comments
Open
12 of 18 tasks

Migrate to cmake #93

luke-jr opened this issue Dec 5, 2024 · 8 comments
Milestone

Comments

@luke-jr
Copy link
Collaborator

luke-jr commented Dec 5, 2024

Bitcoin Core 29.x is switching to CMake instead of Autotools, which means everything touching the build system will need rewriting.

This includes:

Additionally, this removes the major pre-generation step of the source tarball, so it may make sense to just require rsvg-tools and ImageMagick rather than try to pre-render the icons.

(If anyone would like to work on these, ping me to ensure you have the latest branches.)

@luke-jr luke-jr added this to the 29.0 milestone Dec 5, 2024
@michaelfolkson
Copy link

What is the current status of Knots cmake builds? Still needs these final task items to be completed before Knots can be built with cmake?

@luke-jr
Copy link
Collaborator Author

luke-jr commented May 13, 2025

Yes.

win_taskbar_progress is rebased, but needs testing still.

macos_dmg requires more than just CMake at this point; I had to drop it for 28.x in preference for signed/notarised binaries required for Apple to allow users to run the builds at all.

svg_icon and knots_branding are probably trivial (based on experience rebasing tbc_font) if ImageMagick and librsvg2 are made unconditional GUI dependencies.

restore_libconsensus may be difficult

@michaelfolkson
Copy link

Very much a cmake newbie but in the absence of getting help from one of the Core build system guys (hebasto etc) I or someone else could focus on getting up to speed with cmake. Definitely a full time project though (for someone).

@luke-jr
Copy link
Collaborator Author

luke-jr commented May 14, 2025

I'm not sure it's that difficult... maybe full time for a week or two at most.

@michaelfolkson
Copy link

For someone with no prior cmake, build system experience? Ok, if you say so.

@luke-jr
Copy link
Collaborator Author

luke-jr commented May 14, 2025

Maybe add a few weeks for no prior experience. But it makes more sense to have people familiar with things working on those areas, IMO.

@michaelfolkson
Copy link

Sure if someone with that skillset pops up

@luke-jr
Copy link
Collaborator Author

luke-jr commented May 24, 2025

#133 is probably ready for review and testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants